feat(java): detect Jelly form-entry title/description expressions rendered unescaped (CWE-79) - #131
Open
ai-anant wants to merge 1 commit into
Conversation
…dered unescaped (CWE-79)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Jenkins/Jelly rule:
codevigilant.java.jenkins.xss.jelly-entry-unescaped-expression— fires on Jellyviews that disable form-entry escaping (
escapeEntryTitleAndDescription=false)and bind a ${...} expression to an
f:entry/f:blocktitle or descriptionattribute where the expression is neither wrapped in
h.escape(...)nor theMarkupFormatter-sanitized
formattedDescription/getFormattedDescriptiongetter. Config- or user-controlled content reaching such an attribute is emitted
as raw HTML in the Jenkins UI, enabling stored XSS (CWE-79).
Generic vulnerable shape:
Safe shapes excluded via regex lookaheads: h.escape-wrapped expressions and
formatter-sanitized formattedDescription/getFormattedDescription bindings.
Implementation note: Jelly files are XML; semgrep has no XML language, so the
rule runs in generic mode using pattern-inside (escape flag present) plus a
pattern-regex for the unescaped attribute binding. Validated with
semgrep --validate; tested against a positive repro (2 vulnerable entries -fires) and a negative repro (h.escape/formattedDescription/literal bindings -
no findings).