feat(java): detect FilePath.copyFrom called with a non-literal URL (CWE-918) - #124
Open
ai-anant wants to merge 2 commits into
Open
feat(java): detect FilePath.copyFrom called with a non-literal URL (CWE-918)#124ai-anant wants to merge 2 commits into
ai-anant wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detects hudson.FilePath.copyFrom(...) invoked with a non-literal URL argument (e.g. a URL parsed from a remote response, job configuration, or env-expanded build parameter).
copyFrom(URL) opens an outbound connection to the argument URL and writes the response body into the FilePath on the local node, so an attacker-influenced value turns into a server-side request forgery plus an arbitrary-content write to a path the plugin chose.
The rule matches the copyFrom sink only when the argument is a URL expression (new URL(...) or a URL-typed value), and excludes literal URLs. Positive/negative repro cases are included under testcases/java/.
Validated with semgrep --validate; fires on the vulnerable shape (1 hit) and stays silent on the literal/FilePath-to-FilePath negative repros.