feat(java): detect Jelly anchors with tainted href expressions (CWE-79) - #119
Open
ai-anant wants to merge 1 commit into
Open
feat(java): detect Jelly anchors with tainted href expressions (CWE-79)#119ai-anant wants to merge 1 commit into
ai-anant wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Jenkins/Jelly rule:
codevigilant.java.jenkins.xss.jelly-href-tainted— fires on<a href="${...}">in Jelly views when the href is bound to an expression whose scheme is not pinned
to http/https or the Jenkins
rootURLvariable. Server/network/config-derived URLvalues (e.g. an SCM server-supplied base URL concatenated into the href) can carry
a
javascript:ordata:scheme, yielding stored XSS in the Jenkins UI when therendered link is clicked.
Scan note: Jelly files are XML; run with the rule language selected (e.g.
semgrep --config <rules> --lang xml <path>/*.jelly) since.jellyis not insemgrep's default XML extension list.
Validated with
semgrep --validate; tested against a positive repro (two taintedanchors - fires) and a negative repro (rootURL/static https anchors - no findings).