feat(java): detect secret-typed Jenkins jelly fields rendered with f:textbox (CWE-522) - #117
Open
ai-anant wants to merge 1 commit into
Open
Conversation
…instead of f:password (CWE-522)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an XML rule detecting Jenkins config views (jelly) that render a secret-typed field (field name matching apiKey/secret/token/password/credential) with f:textbox instead of f:password. Secret values rendered in a plain textbox are echoed into the config page HTML, browser history and page source, and replay on save; f:password is required so the value is not displayed and changes require explicit re-entry.
Rule: codevigilant.java.jenkins.views.secret-field-textbox
Validated with semgrep --validate; fires on secret-named textbox entries, silent on f:password and non-secret fields.