feat(java): detect doCheck* file-capability probes without a permission check (CWE-200) - #110
Open
ai-anant wants to merge 1 commit into
Open
Conversation
…canExecute/isFile/isDirectory/length) without a permission check (CWE-200)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New rule: Stapler form-validation handlers (doCheck*) that build a java.io.File from handler input and then probe file capabilities (canRead/canWrite/canExecute/isFile/isDirectory/length/listFiles) without an explicit ACL permission check.
Descriptor doCheck* methods are routed directly by Stapler and are not protected by any permission by default, so any user who can reach the descriptor URL can use such an endpoint as a file-capability oracle for arbitrary paths on the controller. Complements the existing exists()-probe rule with the remaining capability-probe sink methods. Handlers guarded by checkPermission(...) are excluded.
Positive and negative testcases included under testcases/java/. Validated with semgrep 1.172 (pos fires, neg clean).