feat(java): detect credential values passed into child-process environment maps (CWE-214) - #109
Open
ai-anant wants to merge 1 commit into
Open
feat(java): detect credential values passed into child-process environment maps (CWE-214)#109ai-anant wants to merge 1 commit into
ai-anant wants to merge 1 commit into
Conversation
…nment maps (CWE-214)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New taint rule: a credential value obtained from a getter such as getPassword()/getSecret()/getPlainText()/getSecretValue()/getToken()/getApiKey() that flows into an environment map (EnvVars or another variable whose name matches 'env') passed to a launched child process.
Credentials placed into a child-process environment are inherited by all descendants, are visible to other processes running under the same OS user on the node (e.g. 'ps eww' on Linux), and appear in process dumps. The rule flags the generic shape so reviewers can route secrets through credential bindings, masked stdin, or permission-protected files instead.
Positive and negative testcases included under testcases/java/. Validated with semgrep 1.172 (pos fires, neg clean).