Repository navigation
Refuse a post that mentions a deactivated account - #244
Merged
Merged
Conversation
Zulip still resolves a deactivated account's name in @**Name** markup, but renders the mention silent, so it notifies nobody. The write-path check resolved names against every member of /users, deactivated ones included, so a post naming a released ephemeral seat went out silently instead of failing with UnresolvedMention. The check now counts only active members, in both the @**Name** and @**Name|id** forms. The read path is unchanged: it already reads the rendered span, which Zulip marks silent.
GraemeF
marked this pull request as ready for review
September 29, 2026 11:46
GraemeF
enabled auto-merge (squash)
September 29, 2026 11:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zulip still resolves a deactivated account's name in
@**Name**markup, but it renders the mention silent, so the mention notifies nobody. commy's write-path check resolved names against every member of/users, deactivated ones included. A post naming a deactivated seat therefore went out silently instead of failing withUnresolvedMention.The check now counts only active members, in both the
@**Name**and@**Name|id**forms. The read path is unchanged, because it reads the rendered span and Zulip already marks that span silent.This PR does not stop a live seat's bot from being deactivated. commy's ephemeral idle sweep does that, and a separate change removes the sweep. After this PR, the author of such a post gets an error instead of silence.