Repository navigation
Build without warnings - #201
Merged
Merged
Conversation
The build and the tests compiled with hundreds of deprecation and concurrency warnings. Now gone: - JSONValue.value, renamed jsonObject (tests and the demo server) - MCPJSONCoding, renamed JSONCoding (seven source files) - JSONRPCSubprocess.StdioMessageTransport, renamed StdioTransport and qualified, because SwiftMCP's server-side StdioTransport shares the name - [String](caseLabelsFrom:), replaced by CaseIterable.caseLabels where it was a usage; the one test of the deprecated initializer runs in a deprecated context - the generic test helpers capture a metatype, so they require SendableMetatype - the two timeout tasks no longer throw: a cancelled sleep ends them quietly - the DNSServiceRef handed to its own queue for deallocation is marked nonisolated(unsafe), which is what that call is 699 tests, swiftlint --strict clean. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build and the tests compiled with hundreds of deprecation and concurrency warnings (the Android CI log alone had about 3,400 lines of them). All gone, with the suite at 699 tests and
swiftlint --strictclean:JSONValue.value→jsonObject(tests and the demo server), rewritten at the exact positions the compiler reported.MCPJSONCoding→JSONCoding(seven source files).StdioMessageTransport→JSONRPCSubprocess.StdioTransport, module-qualified because SwiftMCP's own server-sideStdioTransportshares the name.[String](caseLabelsFrom:)→CaseIterable.caseLabelswhere it was a usage; the one test of the deprecated initializer (nil for a non-CaseIterable type) now runs in a deprecated context.ServerInfoIdentityTestscapture a metatype, so they requireSendableMetatype.Tasks no longer throw: a cancelled sleep ends them quietly, said explicitly.DNSServiceRefhanded to its own queue for deallocation is markednonisolated(unsafe)at both sites, which is what that call is.🤖 Generated with Claude Code