-
-
Notifications
You must be signed in to change notification settings - Fork 5
fix(ledmatrix-flights): give the Vegas map the same features as the rotation #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ChuckBuilds
wants to merge
2
commits into
main
Choose a base branch
from
fix/flights-vegas-map-parity
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| # Changelog | ||
|
|
||
| ## [1.12.6] - 2026-07-29 | ||
|
|
||
| ### Fixed | ||
| - **Vegas scroll map was missing trails, the centre marker and the aircraft | ||
| count**: `get_vegas_content()` reimplemented a cut-down version of the map | ||
| view that drew only the background and the aircraft dots, so aircraft trails | ||
| never appeared in the ticker even with `show_trails` enabled — and neither did | ||
| the white centre-position dot or the aircraft count. Both paths now share a | ||
| single `_render_map_image()`, so the ticker renders the same map as the normal | ||
| rotation and cannot drift from it again. | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major | 🏗️ Heavy lift
Move tile fetching out of the render path.
_get_map_background()can synchronously fetch map tiles on cache misses, and this helper runs from bothdisplay()andget_vegas_content(). A cold cache can therefore stall a rotation/Vegas frame. Refresh tile/background data inupdate()throughself.cache_manager; render from cached data or use the existing black fallback.As per coding guidelines, “Fetch or refresh network data in
update(), never indisplay(), and use the sharedself.cache_managerfor network-fetched data.”🤖 Prompt for AI Agents
Source: Coding guidelines