ledmatrix-stocks: compact layout — definite chart size + content-sized entries by ChuckBuilds · Pull Request #225 · ChuckBuilds/ledmatrix-plugins

ChuckBuilds · 2026-07-28T19:59:53Z

Problem

The stock ticker layout scaled with the display, so it got massive on large/4x panels and in vegas mode:

The mini-chart width was a fraction of the per-entry canvas (display_width × multiplier) and its height a fraction of the display height — so it ballooned on wide chains (e.g. ~204px wide at 256) and on tall 4x panels (e.g. ~85px tall at 128).
The chart was anchored to the far-right of a wide canvas while the price sat on the left, leaving a large empty gap between them (~135px at 256×64).
The per-entry canvas was a fixed display-scaled guess, leaving dead trailing space between tickers.

Changes

Definite chart size. New config display.chart_width_px / display.chart_height_px (default 64×32), a fixed pixel size that does not scale with the display and is clamped to the panel. Replaces chart_width_percent / chart_height_percent.
Chart next to the price. Drawn directly to the right of the price text (small fixed gap) instead of anchored far-right.
Content-sized entries. Each entry canvas is measured (logo + text + chart) and sized to fit, so there's no dead space between tickers — and no chart/text overlap (an earlier clamp-based approach overlapped on narrow panels with a big logo).

Verification

Chart renders a constant 64×32 at 64×128 (tall/4x), 256×64 (wide), and 128×32; no overlap on the tall panel; price→chart gap is a small fixed 6px (was up to 135px).
Vegas-style multi-ticker strips are compact with consistent spacing.
Plugin safety harness passes at all sizes (64×32 → 256×128).

Manifest bumped 2.4.0 → 2.5.0 (config schema change); README + schema updated.

🤖 Generated with Claude Code

https://claude.ai/code/session_01KEZK1P1Q1fu5pcuVrkrCFZ

The inline mini-chart was anchored to the far-right of the per-entry scroll canvas (~2x display width), while the price text sits just right of the logo. On larger panels this left a big empty gap between the price and the chart (e.g. ~135px at 256x64). Draw the chart immediately to the right of the text column (small fixed gap, clamped so it stays on-canvas for unusually wide text), then crop the entry canvas to the content so the leftover space doesn't become dead scroll gap. _draw_mini_chart gains an optional chart_x (defaults to the old right-anchored position). Also removes the now-unneeded text/chart overlap clamp. Verified by rendering mock data: price->chart gap drops from 135px to 6px at 256x64 (already tight at 128x32), no overlap, wide-text case stays on-canvas, and the safety harness passes at all sizes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KEZK1P1Q1fu5pcuVrkrCFZ

coderabbitai · 2026-07-28T20:00:22Z

Warning

Review limit reached

@ChuckBuilds, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 28 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 270e6cfe-c0ad-4a47-8380-8fc449d38083

📥 Commits

Reviewing files that changed from the base of the PR and between 4d78959 and f8f053e.

📒 Files selected for processing (5)

plugins.json
plugins/ledmatrix-stocks/README.md
plugins/ledmatrix-stocks/config_schema.json
plugins/ledmatrix-stocks/display_renderer.py
plugins/ledmatrix-stocks/manifest.json

📝 Walkthrough

Walkthrough

Changes

Stock chart layout

Layer / File(s)	Summary
Inline chart placement and cropping `plugins/ledmatrix-stocks/display_renderer.py`	The mini-chart is positioned beside the text column when enabled, with explicit chart coordinates supported and the canvas cropped to the rendered content.
Plugin release metadata `plugins.json`, `plugins/ledmatrix-stocks/manifest.json`	Plugin version metadata and changelog entries are updated from 2.4.0 to 2.4.1, dated 2026-07-28.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

ChuckBuilds/ledmatrix-plugins#49: Related stock display text-column and chart overlap positioning changes.
ChuckBuilds/ledmatrix-plugins#200: Related mini-chart sizing, placement, and canvas cropping changes.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly reflects the main change: a more compact stock layout with chart placement and content-sized entry cropping.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/stocks-price-chart-gap

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

codacy-production · 2026-07-28T20:01:02Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric Results

Complexity 0

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@plugins/ledmatrix-stocks/display_renderer.py`:
- Around line 299-318: The chart placement in the renderer can overlap the text
when the clamped chart position falls inside the text column. Update the
toggle_chart path around _draw_mini_chart to preserve the intended chart_width
by expanding the rendering canvas before drawing, or skip the chart when it
cannot fit beside text; do not move the chart left into the text area. Ensure
rendering remains correct for all supported matrix sizes.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b1bf0b5f-caae-4364-befa-b46b70d0c1fa

📥 Commits

Reviewing files that changed from the base of the PR and between e1769a0 and 4d78959.

📒 Files selected for processing (3)

plugins.json
plugins/ledmatrix-stocks/display_renderer.py
plugins/ledmatrix-stocks/manifest.json

Make the mini-chart a fixed pixel size (chart_width_px / chart_height_px, default 64x32) instead of a fraction of the display. Previously width was a fraction of the display-scaled canvas and height a fraction of the display height, so the chart ballooned on wide chains and tall 4x panels (and looked "massive" in vegas mode). Also size each entry's canvas to its actual measured content (logo + text + chart) instead of a display-scaled guess that was then clamped. This removes the dead space between tickers and fixes a chart/text overlap that the clamp caused on narrow panels with a large logo. Replaces the chart_width_percent / chart_height_percent config keys with chart_width_px / chart_height_px (README + schema updated). Verified: chart is a constant 64x32 at 64x128, 256x64, 128x32; no overlap on the tall panel; vegas-style strips are compact; safety harness passes at all sizes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KEZK1P1Q1fu5pcuVrkrCFZ

Resolves the plugins.json conflict by taking main's registry and regenerating it with update_registry.py, rather than hand-merging an auto-generated file — a textual merge of it produces invalid JSON. The only resulting difference from main is the stocks bump this branch carries (2.4.0 -> 2.5.0) plus the regenerated timestamps.

coderabbitai Bot reviewed Jul 28, 2026

View reviewed changes

Comment thread plugins/ledmatrix-stocks/display_renderer.py Outdated

ChuckBuilds changed the title ~~fix(ledmatrix-stocks): minimize the gap between the price and the mini-chart~~ ledmatrix-stocks: compact layout — definite chart size + content-sized entries Jul 28, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ledmatrix-stocks: compact layout — definite chart size + content-sized entries - #225

ledmatrix-stocks: compact layout — definite chart size + content-sized entries#225
ChuckBuilds wants to merge 3 commits into
mainfrom
fix/stocks-price-chart-gap

ChuckBuilds commented Jul 28, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jul 28, 2026 •

edited

Loading

Review limit reached

Walkthrough

Changes

Uh oh!

codacy-production Bot commented Jul 28, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

ChuckBuilds commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Changes

Verification

Uh oh!

coderabbitai Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Walkthrough

Changes

Uh oh!

codacy-production Bot commented Jul 28, 2026

Up to standards ✅

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ChuckBuilds commented Jul 28, 2026 •

edited

Loading

coderabbitai Bot commented Jul 28, 2026 •

edited

Loading