-
-
Notifications
You must be signed in to change notification settings - Fork 26
Sports unification phase 0: safety net, cwd-independent fonts, element_style #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1baebd2
fix(fonts): resolve asset paths against the install root, not the cwd
claude 3f4e915
docs: seed CHANGELOG.md with the module-availability release discipline
claude dc65994
ci: enroll the core unit suites in a dedicated job
claude 5fe9c07
feat: ship src/element_style — the per-element style resolver plugins…
claude 1a07922
test: characterization suite for src/base_classes/sports.py ahead of …
claude 64e8f87
ci: restrict the test workflow's GITHUB_TOKEN to contents:read
claude 81a8dcd
Address CodeRabbit review: font-name traversal + offline test guard
ChuckBuilds File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| # Changelog | ||
|
|
||
| Notable changes to the LEDMatrix core. The version below is the value of | ||
| `src.__version__`, which the plugin loader reports to compatibility checks and | ||
| which plugin manifests reference via `ledmatrix_min_version`. | ||
|
|
||
| **Why this file exists:** the plugin monorepo bundles fallback copies of several | ||
| core modules (see `docs/plugin-development/08-shared-sports-code.md` in | ||
| [ledmatrix-plugins](https://github.com/ChuckBuilds/ledmatrix-plugins)). A plugin | ||
| may delete its bundled copy only when its manifest floors on the first core | ||
| release that ships the module — which requires module additions to be recorded | ||
| here, against a version number. When you add a module plugins will import via | ||
| `src.*`, note it in the Unreleased section and bump `src/__init__.py` in the | ||
| release that ships it. | ||
|
|
||
| ## Unreleased | ||
|
|
||
| ### Added | ||
| - `src/element_style.py` — per-element style resolver backing the | ||
| `x-style-elements` config-schema extension. Already consumed (behind guarded | ||
| imports with classic fallbacks) by the `of-the-day`, `ledmatrix-music`, and | ||
| `football-scoreboard` plugins. | ||
| - Core unit-test CI job enrolling the previously unenrolled suites (skin | ||
| system, data sources, API extractors, scroll helper, adaptive layout, loader | ||
| compatibility warning) plus new characterization tests for | ||
| `src/base_classes/sports.py` ahead of the shared sports-code unification. | ||
|
|
||
| ### Fixed | ||
| - `FontManager` resolves `assets/fonts` against the core install root instead | ||
| of the process working directory, so font loading works when the process | ||
| starts elsewhere (e.g. the plugin safety harness on CI). | ||
|
|
||
| ## 3.1.0 | ||
|
|
||
| Baseline for this changelog. Highlights already shipped at this version: | ||
| skin system for sports scoreboards (#419), Vegas continuous-scroll overhaul | ||
| (#423), plugin update surfacing (#421). |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.