Rotary ns 2#70
Closed
nshehz wants to merge 23 commits into
Closed
Conversation
phako
requested changes
Jun 8, 2026
Member
|
Please squash the commits before merging |
nshehz
force-pushed
the
rotary_ns_2
branch
2 times, most recently
from
ef74ad8 to
44f83aa
Compare
phako
approved these changes
Jun 11, 2026
…eaders Refactor copyright and license checks in header files to ensure correct order and presence of SPDX identifiers and #pragma once.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Doxygen does not expand the macros which were used for function declaration and complained that there is no declaration for those functions.
- Don't use included boost tests. They have asan issues. As the old style with manual test suites does not work in the new scheme, all tests have been moved to auto tests.
clang-tidy-14 does not support C++23 and thus was not working any more
- switch to new syntax for readability - no functional changes
- also restore alphabetical order
- remove 'portability-avoid-pragma-once'. Our style require pragma-once - remove 'portability-template-virtual-member-function'. We want and need template virtual member functions.(*) - activate 'misc-include-cleaner' to warn for unused headers - add 'clang-diagnostic-*'. This covers clang compliler warnings. As we have -Wall activated, this entry exceptionally has a wild card so we get the clang compiler warnings in the linter in case we are compiling with g++. -- remove 'missing-noreturn'. It is a clang compiler flag, not a clang-tidy flag. It is covered by 'clang-diagnostic-missing-noreturn' - use 'modernize-use-ranges' (std::ranges) instead of 'boost-use-ranges' (*) It was introduced because someone had broken code that was not instantiated by some compilers and then compilation failed on other compilers. But the issue was the broken code, not the virtual member function. Pretty useless feature.
The namespaced alias for libraries was added twice. When using CMAKE_MINIMUM_REQUIRED 3.18 or higher this causes an error.
Contributor
Author
|
created clean branch and merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.