Skip to content

Use the solution from 38#43

Merged
jacomago merged 4 commits into
masterfrom
38-sky
Mar 24, 2026
Merged

Use the solution from 38#43
jacomago merged 4 commits into
masterfrom
38-sky

Conversation

@jacomago

Copy link
Copy Markdown
Contributor

See #38 for discussion

@sonarqubecloud

Copy link
Copy Markdown

@anderslindho anderslindho left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't #38 then be merged instead/first?

@simon-ess

Copy link
Copy Markdown

@anderslindho - this contains the code from #38.

@anderslindho

Copy link
Copy Markdown

@anderslindho - this contains the code from #38.

I can see that @simon-ess, my point is that we would lose related discussions if this is merged and #38 is closed.

@jacomago

Copy link
Copy Markdown
Contributor Author

@anderslindho - this contains the code from #38.

I can see that @simon-ess, my point is that we would lose related discussions if this is merged and #38 is closed.

I don't have access to the branch for #38 so I can't work on top of it.

@tynanford

Copy link
Copy Markdown
Contributor

Tagging @smarsching from #38

@tynanford tynanford left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacomago jacomago merged commit 62e8f90 into master Mar 24, 2026
6 of 22 checks passed
@jacomago jacomago deleted the 38-sky branch March 24, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants