Bootstrap - #2126
Draft
lukavdplas wants to merge 103 commits into
Draft
Conversation
.columns -> .row .column -> .col-md .has-addons -> .input-group .label -> .form-label remove class="icon" .section -> .py-5 .block -> .my-3 .input -> .form-control .button -> .btn .help -> .form-text find/replace .title -> .mb-4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mega-update to switch from bulma to bootstrap. From here we can also start replacing primeNG components, but I have not started with that yet.
(PrimeNG components still work in the meantime, so they can be replaced one by one.)
This branch is more or less ready, but there are still going to be some small stray issues before it's release-ready. But I think the code should be stable enough that we can pick up different issues in parallel.
Summary of changes:
DropdownComponentnow builds onNgbDropdown. NgbDropdown handles opening/closing the menu, our own component only needs to manage the current selection. API is slightly changed.MenuDropdownComponent(for navbar dropdowns) is replaced byNgbDropdown.TabsComponentis replaced byNgbNav.BalloonDirectiveis replaced byNgbTooltip.ToggleComponentis replaced by theswitchCSS class.is-loadingCSS class is replaced byLoadingDirective.is-loadingCSS class is replaced byButtonLoadingDirective. This one also blocks Enter/Space events while loading. (The CSS class only blocked pointer events.)ConfirmModalComponentnow usesNgbModal;PaginationComponentusesNgbPagination;NotificationsComponentusesNgbToast.tc_theme.scssthat imports bootstrap with customisations. This is meant to separate the theme from the genericstyles.scss, and should make it easier to provide different theme colours in the future.Still to do:
PrimeNG components to replace:
p-dialog-> replace withNgbModalp-datepicker-> replace withNgbDatepicker.p-steps-> useNgbNav(with extra styling)p-autocompletefor query comparison -> build from scratchp-autoCompletefor language selection -> similar, but mix inNgbTypeaheadsomehowp-multiselect-> Could build this directly onNgbDropdown(without a generic "multiselect" component), or build something analogous to our (single-select)DoprdownComponent.p-slider-> there may be a suitable package for multi-thumb bootstrap sliders. Otherwise build from scratch.p-table-> implement filters and pagination (withNgbPagination) without a "table component".