[CR][ENG-10932] oraclecloud storage provider backend for osfstorage#481
Open
felliott wants to merge 17 commits into
Open
[CR][ENG-10932] oraclecloud storage provider backend for osfstorage#481felliott wants to merge 17 commits into
felliott wants to merge 17 commits into
Conversation
…age (#474) * ENG-10556 | Add OracleCloud (OCI) Object Storage provider for osfstorage * ENG-10556 | Add tests for the OracleCloud (OCI) Object Storage provider for osfstorage
…y, and work request polling
…y, and work request polling
Closes #475 [ENG-10557]
* update oci tests for 'json_creds' * remove unneeded metadata_folder * remove unneeded delete_folder code * update folder intra_copy code * move s3 creds under s3compat key * save more progress on signed urls
* Add query params before query parsing so params are part of calculation. * Only include `host` in signed headers list. * Make error-level debuggings just debug-level
* also remove oci from deps
|
coverage: 84.708% (+0.5%) from 84.248% — feature/oci-provider into develop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://openscience.atlassian.net/browse/ENG-10932
Purpose
Finalize oraclecloud provider as storage backend for osfstorage.
Changes
Most of the work in this PR was done by @sh-andriy . Changes:
Still WIP: filling out the test suite. I've commented out some broken tests and need to fix them. I have not added tests for the pre-signed url mechanism.
Side effects
None expected?
QA Notes
Not directly QA-able at this time, needs a test env with creds set up.
Deployment Notes
To be handled offline.