Skip to content

Remove GarminDevices component - #661

Open
chrisnowak wants to merge 1 commit into
mainfrom
claude/remove-garmin-devices-node-f5r840
Open

Remove GarminDevices component#661
chrisnowak wants to merge 1 commit into
mainfrom
claude/remove-garmin-devices-node-f5r840

Conversation

@chrisnowak

Copy link
Copy Markdown
Contributor

Overview

GarminDevices rendered nothing in practice (Garmin exposes no connected device list), so remove the container component along with its story and preview data, its container export, and its usage in GarminView, DeviceDataView, and ConnectDevicesView.

This is technically a "breaking change" but I don't think sufficiently breaking that we need to create a new major version; unlikely external folks are actively using this.

Security

Consider potential security impacts and complete the following checklist.
REMINDER: All file contents are public.

  • I have ensured no secure credentials or sensitive information remain in code, metadata, comments, etc.
    • Please verify that you double checked that .storybook/preview.js does not contain your participant access key details.
    • There are no temporary testing changes committed such as API base URLs, access tokens, print/log statements, etc.
  • These changes do not introduce any security risks, or any such risks have been properly mitigated.

Testing

Consider whether the changes might have device-specific behaviors (screen padding, new APIs, etc.) and check one of the following boxes:

  • This change can be adequately tested using the MDH Storybook.
  • This change requires additional testing in the MDH iOS/Android/Web apps. (Create a pre-release tag/build and test in a ViewBuilder PR.)

Documentation

Consider whether there are any documentation impacts and check one of the following boxes:

  • I have added relevant Storybook updates to this PR.
  • If this feature requires a developer doc update, I have tagged @CareEvolution/api-docs.
  • This change does not impact documentation or Storybook.

Reviewers

Assign to the appropriate reviewer(s). Minimally, a second set of eyes is needed ensure no non-public information is published. Consider also including:

  • Subject-matter experts
  • Style/editing reviewers
  • Others requested by the content owner

Consider "Squash and merge" as needed to keep the commit history reasonable on main.

GarminDevices rendered nothing in practice (Garmin exposes no connected
device list), so remove the container component along with its story and
preview data, its container export, and its usage in GarminView,
DeviceDataView, and ConnectDevicesView.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GWyazgMytMPbkK8sVEb4nv
@aws-amplify-us-east-1

Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-661.d1xp2kmk6zrv44.amplifyapp.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants