refactor: 포트 요약 공통화 및 삭제 관련 조회 개선 - #382
Open
yoon6yo wants to merge 2 commits into
Open
Conversation
- PodPortUtils로 포트 요약 포맷 로직을 추출해 AlarmService, RequestExpiryService에서 공통으로 사용하도록 정리 - AdminUserService.deleteUser()에서 사용자 소유 Request들의 포트를 한 번에 조회해 N+1 쿼리 제거 - 관리자 거절/변경 요청 거절 메일 발송을 try-catch로 감싸 발송 실패가 처리 자체를 막지 않도록 개선 - 미사용 import(Collectors) 제거 Closes #381
FULFILLED 요청이 없는 유저를 삭제할 때도 항상 포트 조회 쿼리가 나가던 것을 조건부로 건너뛰게 하고, AlarmServiceTest의 거의 동일한 mock 헬퍼 두 개를 하나로 합쳤다.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PodPortUtils로 공통화Test plan
./gradlew test --tests "*AlarmServiceTest"./gradlew test --tests "*AdminUserServiceTest"