Repository navigation
Explicit Time Steps - #574
Open
JanNiklasB wants to merge 11 commits into
Open
JanNiklasB wants to merge 11 commits into
JanNiklasB wants to merge 11 commits into
Conversation
This was referenced Jul 22, 2026
Member
Author
|
Closed for now, I will try to reopen it when appropriate, sorry |
Member
Author
|
I am now able to reopen this, sorry for the disruption |
…verTimeEvlotions for compability with deprecation warning
… new versions in example notebooks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
this is the first of two connected PRs to introduce explicit time integration and velocities smaller then c.
Motivation
This PR starts with changing the lengths step integration to time step integration.
Untill now, we used length steps to propagate out particles, which is equivalent to time steps when assuming a constant velocity, in out case the vacuum lightspeed c.
Since I plan to introduce variable velocities in the second PR those two quantities are not the same anymore, and to avoid dividing by v=0 at any given time to convert to time steps, we will need to track the time steps instead and convert to length steps by multiplying the time step with the velocity instead.
Changes
*CurrentStepand*NextStepcalls so time steps are handed overc_lightMaximumTimebreak conditionObserverSpacialEvolutionto observer length stepsObserverTimeEvolutionso it accepts time steps (this and the previous point can be a Problem since they break the interface, I think it is more intuitively to have theObserverTimeEvolutiontake times by default, but we could preserve the old behavior of using length steps.Example Notebooks
I also reran all example notebooks in each of the three PRs so you can see that the old behavior is preserved.