Skip to content

Explicit Time Steps - #574

Open
JanNiklasB wants to merge 11 commits into
CRPropa:masterfrom
JanNiklasB:ExplicitTimeIntegration
Open

JanNiklasB wants to merge 11 commits into
CRPropa:masterfrom
JanNiklasB:ExplicitTimeIntegration

Conversation

@JanNiklasB

@JanNiklasB JanNiklasB commented Jul 22, 2026 •

Copy link
Copy Markdown
Member

Hi,

this is the first of two connected PRs to introduce explicit time integration and velocities smaller then c.

Motivation

This PR starts with changing the lengths step integration to time step integration.
Untill now, we used length steps to propagate out particles, which is equivalent to time steps when assuming a constant velocity, in out case the vacuum lightspeed c.
Since I plan to introduce variable velocities in the second PR those two quantities are not the same anymore, and to avoid dividing by v=0 at any given time to convert to time steps, we will need to track the time steps instead and convert to length steps by multiplying the time step with the velocity instead.

Changes

  • Changed all *CurrentStep and *NextStep calls so time steps are handed over
  • Changed doxygen comments from length step to time step where it is appropriate
  • Added overloads for constructors of propagators so the default is still length steps and the time steps have a different order of arguments. Lengths steps are converted in the constructor to time steps by dividing by c_light
  • Added MaximumTime break condition
  • Added ObserverSpacialEvolution to observer length steps
  • Changed ObserverTimeEvolution so it accepts time steps (this and the previous point can be a Problem since they break the interface, I think it is more intuitively to have the ObserverTimeEvolution take times by default, but we could preserve the old behavior of using length steps.
  • Added some new tests and adjusted old ones

Example Notebooks

I also reran all example notebooks in each of the three PRs so you can see that the old behavior is preserved.

@JanNiklasB

Copy link
Copy Markdown
Member Author

Closed for now, I will try to reopen it when appropriate, sorry

@JanNiklasB JanNiklasB closed this Jul 23, 2026
@JanNiklasB

Copy link
Copy Markdown
Member Author

I am now able to reopen this, sorry for the disruption

@JanNiklasB JanNiklasB reopened this Jul 29, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant