feat: NeoForge artifact#24
Open
obus-globus wants to merge 2 commits into
Open
Conversation
Builds mcef-neoforge from the same sources via ModDevGradle. Publish with: ./gradlew :neoforge:publishToMavenLocal -Pmod_version=<version>
Disable the module's tasks while the NeoForge version does not match the Minecraft version: NeoForge releases lag new Minecraft versions, and a failing neoforge build would otherwise block the push-triggered publishing workflow. Pin the bytecode target to Java 25 (required by NeoForge 26.1; the Fabric artifact stays on 21), declare the version ranges as processResources inputs, and limit the NeoForged repository to its own groups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
neoforge/module that builds and publishesnet.ccbluex:mcef-neoforgefrom the same sources as the Fabric artifact (same code, same java-cef sources, same resources; the only new class is an empty@Mod("mcef")entry point). Companion change for the LiquidBounce NeoForge port (CCBlueX/LiquidBounce#8480), which nests this artifact the way its Fabric jar nestsmcef.The Fabric build and artifact are untouched, and the existing workflows pick the module up as-is:
./gradlew build/publishmatch the module's tasks, and CI already runs on JDK 25, which NeoForge 26.1 requires (the Fabric artifact stays on Java 21). In case NeoForge lags behind after a Minecraft update, the module disables its own tasks with a warning while the NeoForge version does not matchminecraft_version: Fabric is the more important target, and its build and push-triggered snapshot publishing are never blocked by NeoForge.Tested: artifact class listing is identical to the Fabric artifact plus the entry class; consumed by the LiquidBounce NeoForge dev client (browser boots, JCEF renders); both workflows ran locally with act (build green, publish reaches the upload).