Skip to content

Revise dependencies + lock file #219

Description

@confluence

As per discussion:

  1. package-lock.json is not published and has no effect on package installs from npm. We want npm-shrinkwrap.json.
  2. The frontend should be a peer dependency of the controller.
  3. Auth methods should be factored out into plugins. Each plugin should have the controller as a peer dependency. Controller should fail at runtime if no auth plugin found, but not directly depend on any.
  4. Peer dependencies should not be locked (investigate how to do this; can they be removed from the lock file?)
  5. Controller version should only be bumped
  • to bump major version of the frontend
  • to bump frontend version if more specific version is required
  • if there are controller changes

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions