5 OS-MCP generated measures migrated in#1
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates five OpenStudio measures into the gem under lib/measures, adds basic gem/spec validation that the migrated measures are present, and updates CI/docs to reflect the new packaging and testing approach.
Changes:
- Add five migrated OpenStudio measures (Ruby + measure.xml), along with accompanying measure docs and copied Minitest-based measure tests.
- Improve repo usage documentation and add a
Rakefilesobundle exec rake specis the default test entrypoint. - Update CI workflow to run gem specs + Ruby syntax checks, and optionally sync generated
test_resultsto S3.
Reviewed changes
Copilot reviewed 32 out of 47 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| spec/tests/buildingsync_measures_spec.rb | Adds assertions that migrated measures exist with expected files. |
| README.md | Documents how to register measures and run gem/measure tests. |
| Rakefile | Adds rake spec task and sets it as default. |
| lib/measures/set_infiltration_by_ach/tests/set_infiltration_by_ach_test.rb | Adds copied Minitest integration test for the measure. |
| lib/measures/set_infiltration_by_ach/measure.xml | Adds OpenStudio measure metadata for set_infiltration_by_ach. |
| lib/measures/set_infiltration_by_ach/measure.rb | Adds the SetInfiltrationByAch model measure implementation. |
| lib/measures/set_infiltration_by_ach/LICENSE.md | Adds per-measure license placeholder file. |
| lib/measures/set_infiltration_by_ach/docs/ASHRAE_211_L2_SEMANTIC_MAPPING.md | Adds semantic mapping documentation for ASHRAE 211 L2 alignment. |
| lib/measures/set_infiltration_by_ach/docs/.gitkeep | Keeps the docs directory in version control. |
| lib/measures/modify_schedules/tests/modify_schedules_test.rb | Adds copied Minitest integration test for the measure. |
| lib/measures/modify_schedules/measure.xml | Adds OpenStudio measure metadata for modify_schedules. |
| lib/measures/modify_schedules/measure.rb | Adds the ModifySchedules model measure implementation. |
| lib/measures/modify_schedules/LICENSE.md | Adds per-measure license placeholder file. |
| lib/measures/modify_schedules/docs/USAGE.md | Adds detailed usage documentation for schedule payload formats and behavior. |
| lib/measures/modify_schedules/docs/ASHRAE_211_L2_SEMANTIC_MAPPING.md | Adds semantic mapping documentation for ASHRAE 211 L2 alignment. |
| lib/measures/modify_schedules/docs/.gitkeep | Keeps the docs directory in version control. |
| lib/measures/modify_hvac/tests/modify_hvac_test.rb | Adds copied Minitest integration test for the measure. |
| lib/measures/modify_hvac/measure.xml | Adds OpenStudio measure metadata for modify_hvac. |
| lib/measures/modify_hvac/measure.rb | Adds the ModifyHvac model measure implementation. |
| lib/measures/modify_hvac/LICENSE.md | Adds per-measure license placeholder file. |
| lib/measures/modify_hvac/docs/modify_hvac_measure.md | Adds measure reference documentation for modify_hvac. |
| lib/measures/modify_hvac/docs/l2-hvac-audit-translation-plan.md | Adds long-form HVAC audit translation planning document. |
| lib/measures/modify_hvac/docs/ASHRAE_211_L2_SEMANTIC_MAPPING.md | Adds semantic mapping documentation for ASHRAE 211 L2 alignment. |
| lib/measures/modify_hvac/docs/.gitkeep | Keeps the docs directory in version control. |
| lib/measures/modify_envelope_insulation/tests/modify_envelope_insulation_test.rb | Adds copied Minitest integration test for the measure. |
| lib/measures/modify_envelope_insulation/measure.xml | Adds OpenStudio measure metadata for modify_envelope_insulation. |
| lib/measures/modify_envelope_insulation/measure.rb | Adds the ModifyEnvelopeInsulation model measure implementation. |
| lib/measures/modify_envelope_insulation/LICENSE.md | Adds per-measure license placeholder file. |
| lib/measures/modify_envelope_insulation/docs/ASHRAE_211_L2_SEMANTIC_MAPPING.md | Adds semantic mapping documentation for ASHRAE 211 L2 alignment. |
| lib/measures/modify_envelope_insulation/docs/.gitkeep | Keeps the docs directory in version control. |
| lib/measures/disable_sizing_runs/tests/disable_sizing_runs_test.rb | Adds copied Minitest integration test for the measure. |
| lib/measures/disable_sizing_runs/measure.xml | Adds OpenStudio measure metadata for disable_sizing_runs. |
| lib/measures/disable_sizing_runs/measure.rb | Adds the DisableSizingRuns model measure implementation. |
| lib/measures/disable_sizing_runs/LICENSE.md | Adds per-measure license placeholder file. |
| lib/measures/disable_sizing_runs/docs/.gitkeep | Keeps the docs directory in version control. |
| buildingsync-measures.gemspec | Adds minitest dev dependency for the copied measure tests. |
| .gitignore | Ignores an additional lib/measures/test/ path. |
| .github/workflows/test_with_openstudio.yml | Updates CI to run bundle exec rake spec, check Ruby syntax, and conditionally sync artifacts to S3. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@JieXiong9119 can you review the above and let me know if valid? |
kflemin
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
5 New OpenStudio measures. The measures were generated with OpenStudio-MCP to support L200 modeling level of detail during conversion of BuildingSync XML to OpenStudio. The measures are:
Changes: