Skip to content

5 OS-MCP generated measures migrated in#1

Merged
kflemin merged 6 commits into
developfrom
initial-measure-feed
Jul 14, 2026
Merged

5 OS-MCP generated measures migrated in#1
kflemin merged 6 commits into
developfrom
initial-measure-feed

Conversation

@JieXiong9119

@JieXiong9119 JieXiong9119 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

5 New OpenStudio measures. The measures were generated with OpenStudio-MCP to support L200 modeling level of detail during conversion of BuildingSync XML to OpenStudio. The measures are:

  1. disable_sizing_run
  2. modify_envelope_insulation
  3. modify_hvac
  4. modify_schedules
  5. set_infiltration_by_ach

Changes:

  • Add five OpenStudio measures (Ruby + measure.xml), along with accompanying measure docs and copied Minitest-based measure tests.
  • Improve repo usage documentation and add a Rakefile so bundle exec rake spec is the default test entrypoint.
  • Update CI workflow to run gem specs + Ruby syntax checks, and optionally sync generated test_results to S3.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates five OpenStudio measures into the gem under lib/measures, adds basic gem/spec validation that the migrated measures are present, and updates CI/docs to reflect the new packaging and testing approach.

Changes:

  • Add five migrated OpenStudio measures (Ruby + measure.xml), along with accompanying measure docs and copied Minitest-based measure tests.
  • Improve repo usage documentation and add a Rakefile so bundle exec rake spec is the default test entrypoint.
  • Update CI workflow to run gem specs + Ruby syntax checks, and optionally sync generated test_results to S3.

Reviewed changes

Copilot reviewed 32 out of 47 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
spec/tests/buildingsync_measures_spec.rb Adds assertions that migrated measures exist with expected files.
README.md Documents how to register measures and run gem/measure tests.
Rakefile Adds rake spec task and sets it as default.
lib/measures/set_infiltration_by_ach/tests/set_infiltration_by_ach_test.rb Adds copied Minitest integration test for the measure.
lib/measures/set_infiltration_by_ach/measure.xml Adds OpenStudio measure metadata for set_infiltration_by_ach.
lib/measures/set_infiltration_by_ach/measure.rb Adds the SetInfiltrationByAch model measure implementation.
lib/measures/set_infiltration_by_ach/LICENSE.md Adds per-measure license placeholder file.
lib/measures/set_infiltration_by_ach/docs/ASHRAE_211_L2_SEMANTIC_MAPPING.md Adds semantic mapping documentation for ASHRAE 211 L2 alignment.
lib/measures/set_infiltration_by_ach/docs/.gitkeep Keeps the docs directory in version control.
lib/measures/modify_schedules/tests/modify_schedules_test.rb Adds copied Minitest integration test for the measure.
lib/measures/modify_schedules/measure.xml Adds OpenStudio measure metadata for modify_schedules.
lib/measures/modify_schedules/measure.rb Adds the ModifySchedules model measure implementation.
lib/measures/modify_schedules/LICENSE.md Adds per-measure license placeholder file.
lib/measures/modify_schedules/docs/USAGE.md Adds detailed usage documentation for schedule payload formats and behavior.
lib/measures/modify_schedules/docs/ASHRAE_211_L2_SEMANTIC_MAPPING.md Adds semantic mapping documentation for ASHRAE 211 L2 alignment.
lib/measures/modify_schedules/docs/.gitkeep Keeps the docs directory in version control.
lib/measures/modify_hvac/tests/modify_hvac_test.rb Adds copied Minitest integration test for the measure.
lib/measures/modify_hvac/measure.xml Adds OpenStudio measure metadata for modify_hvac.
lib/measures/modify_hvac/measure.rb Adds the ModifyHvac model measure implementation.
lib/measures/modify_hvac/LICENSE.md Adds per-measure license placeholder file.
lib/measures/modify_hvac/docs/modify_hvac_measure.md Adds measure reference documentation for modify_hvac.
lib/measures/modify_hvac/docs/l2-hvac-audit-translation-plan.md Adds long-form HVAC audit translation planning document.
lib/measures/modify_hvac/docs/ASHRAE_211_L2_SEMANTIC_MAPPING.md Adds semantic mapping documentation for ASHRAE 211 L2 alignment.
lib/measures/modify_hvac/docs/.gitkeep Keeps the docs directory in version control.
lib/measures/modify_envelope_insulation/tests/modify_envelope_insulation_test.rb Adds copied Minitest integration test for the measure.
lib/measures/modify_envelope_insulation/measure.xml Adds OpenStudio measure metadata for modify_envelope_insulation.
lib/measures/modify_envelope_insulation/measure.rb Adds the ModifyEnvelopeInsulation model measure implementation.
lib/measures/modify_envelope_insulation/LICENSE.md Adds per-measure license placeholder file.
lib/measures/modify_envelope_insulation/docs/ASHRAE_211_L2_SEMANTIC_MAPPING.md Adds semantic mapping documentation for ASHRAE 211 L2 alignment.
lib/measures/modify_envelope_insulation/docs/.gitkeep Keeps the docs directory in version control.
lib/measures/disable_sizing_runs/tests/disable_sizing_runs_test.rb Adds copied Minitest integration test for the measure.
lib/measures/disable_sizing_runs/measure.xml Adds OpenStudio measure metadata for disable_sizing_runs.
lib/measures/disable_sizing_runs/measure.rb Adds the DisableSizingRuns model measure implementation.
lib/measures/disable_sizing_runs/LICENSE.md Adds per-measure license placeholder file.
lib/measures/disable_sizing_runs/docs/.gitkeep Keeps the docs directory in version control.
buildingsync-measures.gemspec Adds minitest dev dependency for the copied measure tests.
.gitignore Ignores an additional lib/measures/test/ path.
.github/workflows/test_with_openstudio.yml Updates CI to run bundle exec rake spec, check Ruby syntax, and conditionally sync artifacts to S3.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/measures/disable_sizing_runs/tests/disable_sizing_runs_test.rb Outdated
Comment thread lib/measures/modify_hvac/tests/modify_hvac_test.rb Outdated
Comment thread lib/measures/modify_schedules/tests/modify_schedules_test.rb Outdated
Comment thread lib/measures/set_infiltration_by_ach/tests/set_infiltration_by_ach_test.rb Outdated
Comment thread .github/workflows/test_with_openstudio.yml Outdated
Comment thread lib/measures/modify_envelope_insulation/LICENSE.md Outdated
Comment thread lib/measures/modify_hvac/LICENSE.md Outdated
Comment thread lib/measures/modify_schedules/LICENSE.md Outdated
Comment thread lib/measures/set_infiltration_by_ach/LICENSE.md Outdated
Comment thread .github/workflows/test_with_openstudio.yml Outdated
@kflemin

kflemin commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

@JieXiong9119 can you review the above and let me know if valid?

@kflemin
kflemin merged commit d50213b into develop Jul 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants