Skip to content

Release queued inbox receipts after active runs finish - #8216

Merged
steve8708 merged 30 commits into
mainfrom
steve8708/harness-review-regressions-next-20261025
Oct 27, 2026
Merged

steve8708 merged 30 commits into
mainfrom
steve8708/harness-review-regressions-next-20261025

Conversation

@steve8708

Copy link
Copy Markdown
Contributor

What changed

When an inbox sweep sees an ordinary queued message while the current run still has in-flight work, release the receipt for the completion-triggered drain instead of putting it behind a 10-second retry window. Add a regression for that active-tool path while keeping the existing admission-response retry case.

Verification

  • Queued submission inbox spec: 30/30 passed.
  • pnpm guards: all 93 passed.
  • PostgreSQL fencing integration suite: 27/27 passed against a task-local PostgreSQL 17 instance.
  • The matching beta Chat deploy job and smoke succeeded for 320ba2b.
  • The authenticated queued-message E2E on that deployed head failed with background_worker_failed after the direct API returned a durable queued receipt: run 40210677278. This result predates this change and remains under investigation. The busy 409 path remains; this PR makes no claim of a 409 improvement.

@github-actions

github-actions Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Here's a visual recap of what changed:

Visual recap

Open the full interactive recap

builder-io-integration[bot]

This comment was marked as outdated.

builder-io-integration[bot]

This comment was marked as outdated.

builder-io-integration[bot]

This comment was marked as outdated.

builder-io-integration[bot]

This comment was marked as outdated.

builder-io-integration[bot]

This comment was marked as outdated.

builder-io-integration[bot]

This comment was marked as outdated.

builder-io-integration[bot]

This comment was marked as outdated.

builder-io-integration[bot]

This comment was marked as outdated.

…iew-regressions-next-20261025

# Conflicts:
#	packages/core/src/server/agent-chat-plugin.queued-submission-inbox.spec.ts
#	verification/execution-lease/NOTES.md
#	verification/execution-lease/manifest.json
builder-io-integration[bot]

This comment was marked as outdated.

…3089235

# Conflicts:
#	verification/execution-lease/ExecutionLease.tla
#	verification/execution-lease/NOTES.md
#	verification/execution-lease/manifest.json
builder-io-integration[bot]

This comment was marked as outdated.

builder-io-integration[bot]

This comment was marked as outdated.

builder-io-integration[bot]

This comment was marked as outdated.

builder-io-integration[bot]

This comment was marked as outdated.

@builder-io-integration builder-io-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builder reviewed your changes and has a few items to flag 🟡

Review Details

Incremental review summary

The latest update moves providerDispatchStarted until after approve() returns, and adds regression coverage for a synchronous local rejection. That fixes the synchronous ACP-not-pending case. The existing approval-dispatch comment remains open: an asynchronous approve() rejection before the provider accepts the approval can still be classified as an unknown provider outcome. I did not repost it because the same issue is already covered by the open thread.

I found no other confirmed new issues in the reviewed update. The continuation/inbox-ordering issue from the prior round was already resolved and is not part of the current open comments. No files were changed.

🧪 Browser testing: Skipped — infra unavailable. pnpm install setup and the restart attempt fail on toolkit TypeScript TS2883 errors.

@steve8708
steve8708 merged commit 798991f into main Oct 27, 2026
76 checks passed
@steve8708
steve8708 deleted the steve8708/harness-review-regressions-next-20261025 branch October 27, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant