Repository navigation
Release queued inbox receipts after active runs finish - #8216
Conversation
|
Here's a visual recap of what changed: Open the full interactive recap |
…iew-regressions-next-20261025 # Conflicts: # packages/core/src/server/agent-chat-plugin.queued-submission-inbox.spec.ts # verification/execution-lease/NOTES.md # verification/execution-lease/manifest.json
…iew-regressions-next-20261025
…iew-regressions-next-20261025
…iew-regressions-next-20261025
…3089235 # Conflicts: # verification/execution-lease/ExecutionLease.tla # verification/execution-lease/NOTES.md # verification/execution-lease/manifest.json
There was a problem hiding this comment.
Builder reviewed your changes and has a few items to flag 🟡
Review Details
Incremental review summary
The latest update moves providerDispatchStarted until after approve() returns, and adds regression coverage for a synchronous local rejection. That fixes the synchronous ACP-not-pending case. The existing approval-dispatch comment remains open: an asynchronous approve() rejection before the provider accepts the approval can still be classified as an unknown provider outcome. I did not repost it because the same issue is already covered by the open thread.
I found no other confirmed new issues in the reviewed update. The continuation/inbox-ordering issue from the prior round was already resolved and is not part of the current open comments. No files were changed.
🧪 Browser testing: Skipped — infra unavailable. pnpm install setup and the restart attempt fail on toolkit TypeScript TS2883 errors.

What changed
When an inbox sweep sees an ordinary queued message while the current run still has in-flight work, release the receipt for the completion-triggered drain instead of putting it behind a 10-second retry window. Add a regression for that active-tool path while keeping the existing admission-response retry case.
Verification
pnpm guards: all 93 passed.320ba2b.background_worker_failedafter the direct API returned a durable queued receipt: run 40210677278. This result predates this change and remains under investigation. The busy409path remains; this PR makes no claim of a409improvement.