Repository navigation
Stabilize Design E2E and feedback inventory parsing - #8176
Conversation
|
Here's a visual recap of what changed: Open the full interactive recap |
There was a problem hiding this comment.
Builder reviewed your changes and has a few items to flag 🟡
Review Details
Incremental review of PR #8176 at the latest head. The changes still comprise the Design Workbench dependency pre-scan, grouped-grid geometry checks, and Slack feedback-inventory trailer parsing. Standard risk: the parser affects inventory output, while the remaining changes support test/development stability. The previous medium finding is fixed: waitForTargetGridBoxes now polls until the preview has rendered all nodes, and its review thread has been resolved. The one-evaluation measurement and extracted metadata parsers remain sound overall; I found no new high- or medium-severity issues.
New findings
- ⚪ LOW — The trailer regex does not handle CRLF-delimited messages, so the notification trailer and preceding workflow reaction may remain unparsed.
- ⚪ LOW — A user-authored line that exactly resembles valid
Files:/Reactions:metadata may be reclassified as metadata when followed by an App notification trailer.
🧪 Browser testing: Skipped — the browser-test planner is unavailable; the current changes do not affect user-facing UI behavior.

Changes
Verification
templates/design/e2e/grouped-grid-drop.spec.ts: 1 passed, including drag, undo, redo, and reload.templates/design/e2e/code-workbench-local-files.spec.ts: 1 passed, including language selection and consented save.pnpm guards: all 93 checks passed.oxfmt --checkandgit diff --checkpassed.This was sent from a bot