Skip to content

Stabilize Design E2E and feedback inventory parsing - #8176

Merged
steve8708 merged 2 commits into
mainfrom
feedback-checker-design-e2e-20261024
Oct 24, 2026
Merged

steve8708 merged 2 commits into
mainfrom
feedback-checker-design-e2e-20261024

Conversation

@steve8708

Copy link
Copy Markdown
Contributor

Changes

  • Pre-scan the lazy Design Code Workbench so Monaco dependencies are ready before the first browser load.
  • Read grouped-grid item geometry in one preview-frame evaluation, avoiding races during reload.
  • Strip only connector-added Slack thread trailers after valid reaction or file metadata, preserving the metadata used by the feedback inventory.

Verification

  • templates/design/e2e/grouped-grid-drop.spec.ts: 1 passed, including drag, undo, redo, and reload.
  • templates/design/e2e/code-workbench-local-files.spec.ts: 1 passed, including language selection and consented save.
  • Feedback inventory checker self-test: 244 negative cases, 39 positive inventory cases, 6 source-evidence cases, 6 handoff cases, and 8 scope-gate cases passed.
  • pnpm guards: all 93 checks passed.
  • oxfmt --check and git diff --check passed.

This was sent from a bot

@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Here's a visual recap of what changed:

Visual recap

Open the full interactive recap

builder-io-integration[bot]

This comment was marked as outdated.

@builder-io-integration builder-io-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builder reviewed your changes and has a few items to flag 🟡

Review Details

Incremental review of PR #8176 at the latest head. The changes still comprise the Design Workbench dependency pre-scan, grouped-grid geometry checks, and Slack feedback-inventory trailer parsing. Standard risk: the parser affects inventory output, while the remaining changes support test/development stability. The previous medium finding is fixed: waitForTargetGridBoxes now polls until the preview has rendered all nodes, and its review thread has been resolved. The one-evaluation measurement and extracted metadata parsers remain sound overall; I found no new high- or medium-severity issues.

New findings

  • ⚪ LOW — The trailer regex does not handle CRLF-delimited messages, so the notification trailer and preceding workflow reaction may remain unparsed.
  • ⚪ LOW — A user-authored line that exactly resembles valid Files:/Reactions: metadata may be reclassified as metadata when followed by an App notification trailer.

🧪 Browser testing: Skipped — the browser-test planner is unavailable; the current changes do not affect user-facing UI behavior.

@steve8708
steve8708 merged commit 9ad1434 into main Oct 24, 2026
122 checks passed
@steve8708
steve8708 deleted the feedback-checker-design-e2e-20261024 branch October 24, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant