Fixed the original source files, so that they compile on modern Windows and Linux systems#22
Open
wouterbeek wants to merge 17 commits into
Open
Fixed the original source files, so that they compile on modern Windows and Linux systems#22wouterbeek wants to merge 17 commits into
wouterbeek wants to merge 17 commits into
Conversation
…red the same file on Windows). In the original code, these files seem to contain almost the same content, bit with small variations.
… C++11. This is no longer needed with recent versions of MSVC.
…be found in Graph.h.
…window::wair_for_button.
…hich then converted to bool).
… to subdirectory 'src'. This allows us to identify the include directory more clearly in the build process. Also grouped library files into a subdirectory that has the same name as the library. Use <>-notation i.o. ""-notation for includes, so that we only look in the compiler-specified include directories.
… can be processed by editors/IDE's to improve tooling support.
…ludes all and only those FLTK headers which it actually needs.
… major/minor macros were deprecated in glibc 2.25 in 2017-02, and were removed in glibc 2.28 in 2018-08. This means that these undef lines are useless unless somebody is using a C library that is more than 8 years old.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I was reading the PPP book, I was surprised to find that the orignal code does not compile and contains many issues (see 'readme.md' for details). I have also simplified building the code, including pulling in FLTK from a modern package manager.
I hope that these improvements will make it easier for others to use the code when they read the PPP book.
See the descriptions of the individual commits for more details on what was changed.