feat(passkey-crypto): add removePasskeyFromAccount function - #8639
Merged
Conversation
derranW26
force-pushed
the
passkey/ticket-6-remove-passkey-from-account
branch
from
April 28, 2026 14:39
a2b2564 to
c18a4d4
Compare
derranW26
changed the base branch from
passkey/ticket-1-passkey-crypto-package
to
master
April 28, 2026 14:39
derranW26
force-pushed
the
passkey/ticket-6-remove-passkey-from-account
branch
from
May 4, 2026 05:00
c18a4d4 to
98dfc2d
Compare
derranW26
marked this pull request as ready for review
May 4, 2026 05:06
derranW26
force-pushed
the
passkey/ticket-6-remove-passkey-from-account
branch
from
May 4, 2026 14:25
23382f8 to
2f80518
Compare
Contributor
Author
|
@claude review this pr |
derranW26
force-pushed
the
passkey/ticket-6-remove-passkey-from-account
branch
from
May 4, 2026 18:09
2f80518 to
7e7382f
Compare
- DELETE /user/otp/{device.id} to remove a passkey from the account
- Validates device.id before making the API call
- Imports BitGoBase from @bitgo/sdk-core
WCN-191
derranW26
force-pushed
the
passkey/ticket-6-remove-passkey-from-account
branch
from
May 4, 2026 19:05
7e7382f to
b062c83
Compare
mohammadalfaiyazbitgo
approved these changes
May 5, 2026
derranW26
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
modules/sdk-core/src/bitgo/passkey/module withremovePasskeyFromAccount,WebAuthnOtpDevicetype, and barrelindex.tsremovePasskeyFromAccountissuesDELETE /api/v2/user/otp/{device.id}usingdevice.id(notcredentialId)modules/sdk-core/src/bitgo/index.tsdevice.idusage and nocredentialIdleakageNotes
WebAuthnOtpDeviceis a local stub — swap to@bitgo/public-typesonce that PR merges (TODO comment in types.ts)removePasskeyFromWallet()for all affected wallets before calling this function (JSDoc warning on the function)Ticket
WCN-191