Skip to content

Make close button after action is completed not open confirmation - #431

Open
TheLazySquid wants to merge 1 commit into
BetterDiscord:developmentfrom
TheLazySquid:no-prompt-when-done
Open

Make close button after action is completed not open confirmation#431
TheLazySquid wants to merge 1 commit into
BetterDiscord:developmentfrom
TheLazySquid:no-prompt-when-done

Conversation

@TheLazySquid

Copy link
Copy Markdown

Summary

This PR makes the "Quit" button after installing not open the system prompt to confirm whether the user wants to quit installation. I believe that this prompt is unintentional, since it is unnecessary and makes the install process a bit clunkier. The quit button is disabled mid-action so there is no risk of the user accidentally quitting while the install is still happening.

Type of change

  • Bug fix
  • New feature / behavior change
  • UI / component change (frontend)
  • Backend / installer logic (Go)
  • Build / release / CI
  • Refactor (no behavior change)
  • Documentation
  • Other:

Testing

  • bun run check passes (frontend, from frontend/)
  • bun run lint passes (frontend, from frontend/)
  • bun run test passes (frontend, from frontend/)
  • go test ./... passes (backend)

AI disclosure

  • I did not use AI assistance for this PR
  • I used AI assistance and personally reviewed all generated output before submitting
  • An AI agent generated part or all of this PR with minimal personal review. Details:

@zerebos

zerebos commented Aug 30, 2026

Copy link
Copy Markdown
Member

It was intentional to have a quit prompt there rather than just exiting. But I will give this some thought.

@Zacam

Zacam commented Sep 4, 2026

Copy link
Copy Markdown

Pretty Please:

Instead of "Quit", can it just say Exit instead, and if the install progress is successful, not popup a confirmation Dialogue framed to ask if the user wants to "Cancel the Installation"?

Because the current behavior implies or can make people think that it's going to undo doing the install if they "Quit" on a successful install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants