Add commit message template TIL - #33
Open
BenGitsCode wants to merge 4 commits into
Open
BenGitsCode wants to merge 4 commits into
BenGitsCode wants to merge 4 commits into
Conversation
- Just a placeholder title for now, so I remember to come back to this and write it out when I have the time.
- I love them. - I've left this branch ignored for waaay too long. Time to finish it up and make a PR. - These are two of my favorite little git tricks too.
- Adds instructions for setting up a template, as well as an example of the one I use most.
- Git is a proper noun.
laurpaik-zz
reviewed
Nov 3, 2017
| # | ||
| ``` | ||
|
|
||
| What many people don't realize, is that you can actually customize that message. Doing so allows you to not only have a nice guide for your |
Collaborator
There was a problem hiding this comment.
I think that comma is misplaced, but I don't know where it's supposed to go, so I'm improvising a suggestion:
- What many people don't realize, is that you can actually customize that message.
+ You can actually customize that message!
Collaborator
There was a problem hiding this comment.
I just want to clarify-- that default message is supposed to show up every time, correct? I followed your instructions -- my commit message shows up before the default, but it doesn't replace the default like I originally thought.
|
|
||
| 1. Some visual of the line length so I don't go over (plenty of text editor plugins that will do this just as well...or better) | ||
| 1. A reminder to use imperative language in the subject line. | ||
| 1. A couple questions that get me thinking not just about what the change is and not even just why make the change? These questions help me |
Collaborator
There was a problem hiding this comment.
This sentence doesn't make sense 😱 Is this what you meant?
- A couple questions that get me thinking not just about what the change is and not even just why make the change?
+ A couple questions that get me thinking not just about _what_ the change is, but also _why_ make the change?| 1. Some visual of the line length so I don't go over (plenty of text editor plugins that will do this just as well...or better) | ||
| 1. A reminder to use imperative language in the subject line. | ||
| 1. A couple questions that get me thinking not just about what the change is and not even just why make the change? These questions help me | ||
| get at the _most important concept_ behind a commit. Yes, why did you make the change, but also _for what purpose / towards what objective_. |
Collaborator
There was a problem hiding this comment.
I don't quite follow the difference between "why did you make the change" and "for what purpose towards what objective." If that's what you meant, could I get an example?
My instinct tells me "Yes, what change did you make, but also for what purpose / towards what objective." but that's just because I don't see the difference between 'why' and 'for what purpose'
| 1. A couple questions that get me thinking not just about what the change is and not even just why make the change? These questions help me | ||
| get at the _most important concept_ behind a commit. Yes, why did you make the change, but also _for what purpose / towards what objective_. | ||
| 1. A nice glossary of leading active verbs for the subject line. I often find myself gazing down there and rewriting my subject line in | ||
| accordance with one of these. I don't always follow those leading active verbs militantly--but my commits are always better when I do. |
Collaborator
There was a problem hiding this comment.
redundant
- I don't always follow those leading active verbs militantly--but my commits are always better when I do.
+ I don't follow those leading active verbs militantly, but my commits are always better when I do.or
- I don't always follow those leading active verbs militantly--but my commits are always better when I do.
+ I don't always follow those suggestions, but my commits are always better when I do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.