Conversation
mejango
marked this pull request as ready for review
June 23, 2026 13:28
mejango
marked this pull request as draft
June 23, 2026 14:10
Author
|
This has not been deemed severe to the point where a redeploy is recommended. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds regression tests and an implementation fix for same-timestamp reserve minting before scorecard submission.
DefifaHooknow recordslastReserveMintTimestampwhen reserves are minted.DefifaGovernor.submitScorecardForrejects scorecard submission in the same timestamp as the most recent reserve mint, then allows submission in the next timestamp with the reserve holder included normally.What this fixes
A same-block reserve mint before scorecard submission could remove pending-reserve dilution from the denominator while the historical checkpoint still excluded the newly minted reserve. That could inflate the paid holder's BWA.
The new ordering guard closes the same-timestamp path without broadly disabling reserve minting during scoring.
Validation
forge test --root defifa --match-path test/regression/FixPendingReserveDilution.t.solResult: 4 passed.
forge build --deny notes --skip "*/test/**" --skip "*/script/**"Result: passed.
forge test --deny notes --fail-fast --summary --detailed --skip "*/script/**"Result: passed. Full local suite completed with no failures.