Fix blur in Dolphin settings and properties dialogs - #347
Draft
TchelloSimis wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When Darkly's translucent colors or opacity settings are used, Dolphin's main window is blurred correctly, but its Configure dialog is only transparent. The wallpaper and windows behind it remain sharp.
blurSettingsDialogRegion()currently accepts onlyKAboutApplicationDialogandKDEPrivate::KAboutKdeDialog, so a normal Dolphin dialog produces no blur region for KWin.Change
For non-About dialogs in Dolphin, request blur for the full client area. Opaque pixels remain visually unaffected, while translucent panels receive the expected compositor blur. About dialogs continue through their existing tab-specific path.
Verification
Thank you for maintaining Darkly.