Skip to content

Add architect-reviewer skill, lenses, and agent#427

Open
moumighosh wants to merge 2 commits intomasterfrom
moghosh/architect-reviewer-brief-agent
Open

Add architect-reviewer skill, lenses, and agent#427
moumighosh wants to merge 2 commits intomasterfrom
moghosh/architect-reviewer-brief-agent

Conversation

@moumighosh
Copy link
Copy Markdown

No description provided.

@moumighosh moumighosh requested a review from a team as a code owner April 27, 2026 20:43
@github-actions
Copy link
Copy Markdown

❌ Work item link check failed. Description does not contain AB#{ID}.

Click here to Learn more.

@moumighosh
Copy link
Copy Markdown
Author

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 27, 2026

@copilot link this https://identitydivision.visualstudio.com/Engineering/_workitems/edit/3587751 to the PR

Added AB#3587751 to the PR description to link the ADO work item.

- Any data crossing a trust boundary must be described with its protection mechanism
- New trust boundaries introduced by the design must be explicitly justified

### STRIDE Analysis — Minimum Coverage Required
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have a threat model skill already in the repo that does STRIDE analysis along with actual .tm7 threat model diagram.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could consider invoking that here as opposed to adding STRIDE specific logic here.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, we want to reduce the likelihood of skill clashing so if we can use a skill to leverage an existing skill, that will certainly help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants