[AutoPR azure-resourcemanager-netapp]-generated-from-SDK Generation - Java-6412798#49430
Open
azure-sdk wants to merge 3 commits into
Open
[AutoPR azure-resourcemanager-netapp]-generated-from-SDK Generation - Java-6412798#49430azure-sdk wants to merge 3 commits into
azure-sdk wants to merge 3 commits into
Conversation
…pp/NetApp/tspconfig.yaml', SDK Release Type: stable, and CommitSHA: 'f2ea7f9beb3b3a51a0ccf40a9503ca78cf8e7463' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6411999 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
azure-sdk
requested review from
a team,
ArthurMa1978,
XiaofeiCao,
haolingdong-msft and
weidongxu-microsoft
as code owners
github-actions
Bot
added
the
Mgmt
Contributor
There was a problem hiding this comment.
Pull request overview
This is an AutoPR updating the azure-resourcemanager-netapp management SDK from the latest TypeSpec config in azure-rest-api-specs (commit f2ea7f9...) and promoting the package to a stable 2.3.0 release.
Changes:
- Update
tsp-location.yamlpin and refresh generated sources/tests/metadata from the referenced spec commit. - Promote package version from
2.3.0-beta.1to2.3.0(README, POM, changelog, and central version tracking). - Public API change:
Caches/CacheoperationspoolChangeandresetSmbPasswordnow returnCacheinstead ofvoid(with corresponding implementation updates).
Reviewed changes
Copilot reviewed 18 out of 44 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/netapp/azure-resourcemanager-netapp/tsp-location.yaml | Updates spec repo commit pin used for generation. |
| sdk/netapp/azure-resourcemanager-netapp/src/test/java/com/azure/resourcemanager/netapp/generated/UserAssignedIdentityTests.java | Regenerated test data for model deserialization. |
| sdk/netapp/azure-resourcemanager-netapp/src/test/java/com/azure/resourcemanager/netapp/generated/SubvolumesListByVolumeMockTests.java | Regenerated mock test payloads/args/assertions. |
| sdk/netapp/azure-resourcemanager-netapp/src/test/java/com/azure/resourcemanager/netapp/generated/SubvolumesGetWithResponseMockTests.java | Regenerated mock test payloads/args/assertions. |
| sdk/netapp/azure-resourcemanager-netapp/src/test/java/com/azure/resourcemanager/netapp/generated/SubvolumesGetMetadataMockTests.java | Regenerated mock test payloads/args/assertions. |
| sdk/netapp/azure-resourcemanager-netapp/src/test/java/com/azure/resourcemanager/netapp/generated/SubvolumesDeleteMockTests.java | Regenerated mock test args. |
| sdk/netapp/azure-resourcemanager-netapp/src/test/java/com/azure/resourcemanager/netapp/generated/SubvolumesCreateMockTests.java | Regenerated mock test payloads/args/assertions. |
| sdk/netapp/azure-resourcemanager-netapp/src/test/java/com/azure/resourcemanager/netapp/generated/PoolsListMockTests.java | Regenerated mock test payloads/args/assertions. |
| sdk/netapp/azure-resourcemanager-netapp/src/test/java/com/azure/resourcemanager/netapp/generated/PoolsGetWithResponseMockTests.java | Regenerated mock test payloads/args/assertions. |
| sdk/netapp/azure-resourcemanager-netapp/src/test/java/com/azure/resourcemanager/netapp/generated/PoolsCreateOrUpdateMockTests.java | Regenerated mock test payloads/args/assertions. |
| sdk/netapp/azure-resourcemanager-netapp/src/test/java/com/azure/resourcemanager/netapp/generated/NetAppResourceUsagesListMockTests.java | Regenerated mock test payloads/args. |
| sdk/netapp/azure-resourcemanager-netapp/src/test/java/com/azure/resourcemanager/netapp/generated/NetAppResourceUsagesGetWithResponseMockTests.java | Regenerated mock test payloads/args. |
| sdk/netapp/azure-resourcemanager-netapp/src/test/java/com/azure/resourcemanager/netapp/generated/NetAppResourcesUpdateNetworkSiblingSetMockTests.java | Regenerated mock test payloads/args/assertions. |
| sdk/netapp/azure-resourcemanager-netapp/src/test/java/com/azure/resourcemanager/netapp/generated/NetAppResourcesQueryRegionInfoWithResponseMockTests.java | Regenerated mock test payloads/args/assertions. |
| sdk/netapp/azure-resourcemanager-netapp/src/test/java/com/azure/resourcemanager/netapp/generated/NetAppResourcesQueryNetworkSiblingSetWithResponseMockTests.java | Regenerated mock test payloads/args/assertions. |
| sdk/netapp/azure-resourcemanager-netapp/src/test/java/com/azure/resourcemanager/netapp/generated/NetAppResourcesCheckQuotaAvailabilityWithResponseMockTests.java | Regenerated mock test payloads/args/assertions. |
| sdk/netapp/azure-resourcemanager-netapp/src/test/java/com/azure/resourcemanager/netapp/generated/NetAppResourcesCheckNameAvailabilityWithResponseMockTests.java | Regenerated mock test payloads/args/assertions. |
| sdk/netapp/azure-resourcemanager-netapp/src/test/java/com/azure/resourcemanager/netapp/generated/NetAppResourcesCheckFilePathAvailabilityWithResponseMockTests.java | Regenerated mock test payloads/args/assertions. |
| sdk/netapp/azure-resourcemanager-netapp/src/test/java/com/azure/resourcemanager/netapp/generated/NetAppResourceRegionInfosListMockTests.java | Regenerated mock test payloads/args/assertions. |
| sdk/netapp/azure-resourcemanager-netapp/src/test/java/com/azure/resourcemanager/netapp/generated/NetAppResourceRegionInfosGetWithResponseMockTests.java | Regenerated mock test payloads/args/assertions. |
| sdk/netapp/azure-resourcemanager-netapp/src/test/java/com/azure/resourcemanager/netapp/generated/NetAppResourceQuotaLimitsListMockTests.java | Regenerated mock test payloads/args. |
| sdk/netapp/azure-resourcemanager-netapp/src/test/java/com/azure/resourcemanager/netapp/generated/NetAppResourceQuotaLimitsGetWithResponseMockTests.java | Regenerated mock test payloads/args. |
| sdk/netapp/azure-resourcemanager-netapp/src/test/java/com/azure/resourcemanager/netapp/generated/ManagedServiceIdentityTests.java | Regenerated test data for model deserialization. |
| sdk/netapp/azure-resourcemanager-netapp/src/test/java/com/azure/resourcemanager/netapp/generated/CachesResetSmbPasswordMockTests.java | Removed generated mock test for caches reset SMB password operation. |
| sdk/netapp/azure-resourcemanager-netapp/src/test/java/com/azure/resourcemanager/netapp/generated/CachesPoolChangeMockTests.java | Removed generated mock test for caches pool change operation. |
| sdk/netapp/azure-resourcemanager-netapp/src/test/java/com/azure/resourcemanager/netapp/generated/AccountsRenewCredentialsMockTests.java | Regenerated mock test args. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/resources/META-INF/azure-resourcemanager-netapp_metadata.json | Adds cross-language package/version metadata; refreshes generated files list. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/models/NetAppResourceUsages.java | Docstring tweak: clarify location is an Azure region. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/models/NetAppResources.java | Docstring tweaks: clarify location is an Azure region across operations. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/models/Caches.java | API signature change: poolChange/resetSmbPassword now return Cache. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/models/Cache.java | API signature change: instance methods now return Cache. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/implementation/NetAppResourceUsagesClientImpl.java | Docstring tweaks matching public interfaces. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/implementation/NetAppResourcesClientImpl.java | Docstring tweaks matching public interfaces. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/implementation/CachesImpl.java | Implements new return types by wrapping CacheInner as Cache. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/implementation/CachesClientImpl.java | Updates LRO polling + final result types to CacheInner for these operations. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/implementation/CacheImpl.java | Instance methods now return Cache. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/fluent/NetAppResourceUsagesClient.java | Docstring tweaks matching public interfaces. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/fluent/NetAppResourcesClient.java | Docstring tweaks matching public interfaces. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/fluent/CachesClient.java | Fluent client signature updates for LRO + sync return values. |
| sdk/netapp/azure-resourcemanager-netapp/SAMPLE.md | Regenerated samples; one networkSiblingSetStateId sample value changed format. |
| sdk/netapp/azure-resourcemanager-netapp/README.md | Updates dependency snippet to 2.3.0. |
| sdk/netapp/azure-resourcemanager-netapp/pom.xml | Sets package version to 2.3.0 and enables Revapi checks (revapi.skip=false). |
| sdk/netapp/azure-resourcemanager-netapp/CHANGELOG.md | Finalizes 2.3.0 release entry and lists breaking changes. |
| eng/versioning/version_client.txt | Updates central version tracking to 2.3.0. |
Comment on lines
44
to
49
| <properties> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <jacoco.min.linecoverage>0</jacoco.min.linecoverage> | ||
| <jacoco.min.branchcoverage>0</jacoco.min.branchcoverage> | ||
| <revapi.skip>true</revapi.skip> | ||
| <revapi.skip>false</revapi.skip> | ||
| </properties> |
Comment on lines
1599
to
1602
| .withSubnetId( | ||
| "/subscriptions/9760acf5-4638-11e7-9bdb-020073ca7778/resourceGroups/myRP/providers/Microsoft.Network/virtualNetworks/testVnet/subnets/testSubnet") | ||
| .withNetworkSiblingSetStateId("12345_44420.8001578125") | ||
| .withNetworkSiblingSetStateId("1.2345444208001578E9") | ||
| .withNetworkFeatures(NetworkFeatures.STANDARD), com.azure.core.util.Context.NONE); |
Comment on lines
141
to
146
| * @throws RuntimeException all other wrapped checked exceptions if the request fails to be sent. | ||
| * @return cache resource. | ||
| */ | ||
| void poolChange(String resourceGroupName, String accountName, String poolName, String cacheName, | ||
| Cache poolChange(String resourceGroupName, String accountName, String poolName, String cacheName, | ||
| PoolChangeRequest body); | ||
|
|
…pp/NetApp/tspconfig.yaml', SDK Release Type: stable, and CommitSHA: 'bbbd4cf3a9a3a2cdcc2b844862f55ba735048508' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6412293 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
azure-sdk
changed the title
…pp/NetApp/tspconfig.yaml', SDK Release Type: stable, and CommitSHA: '9280f5a9adfdf0cc051f59f5ade2b2642dc1b472' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6412798 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
azure-sdk
changed the title
Comment on lines
+5
to
+6
| - Azure Resource Manager NetAppFiles client library for Java. This package contains Microsoft Azure SDK for NetAppFiles Management SDK. Microsoft NetApp Files Azure Resource Provider specification. Package api-version 2026-04-01. For documentation on how to use this package, please see [Azure Management Libraries for Java](https://aka.ms/azsdk/java/mgmt). | ||
| - Azure Resource Manager NetAppFiles client library for Java. This package contains Microsoft Azure SDK for NetAppFiles Management SDK. Microsoft NetApp Files Azure Resource Provider specification. Package api-version 2026-01-01. For documentation on how to use this package, please see [Azure Management Libraries for Java](https://aka.ms/azsdk/java/mgmt). |
Member
There was a problem hiding this comment.
It generated twice? Which api-version is the target release?
Comment on lines
+12
to
+15
| * `void poolChange(java.lang.String,java.lang.String,java.lang.String,java.lang.String,models.PoolChangeRequest,com.azure.core.util.Context)` -> `models.Cache poolChange(java.lang.String,java.lang.String,java.lang.String,java.lang.String,models.PoolChangeRequest,com.azure.core.util.Context)` | ||
| * `void resetSmbPassword(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.azure.core.util.Context)` -> `models.Cache resetSmbPassword(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.azure.core.util.Context)` | ||
| * `void resetSmbPassword(java.lang.String,java.lang.String,java.lang.String,java.lang.String)` -> `models.Cache resetSmbPassword(java.lang.String,java.lang.String,java.lang.String,java.lang.String)` | ||
| * `void poolChange(java.lang.String,java.lang.String,java.lang.String,java.lang.String,models.PoolChangeRequest)` -> `models.Cache poolChange(java.lang.String,java.lang.String,java.lang.String,java.lang.String,models.PoolChangeRequest)` |
Member
There was a problem hiding this comment.
Why all these breaks on return type of the API (is it FinalResult of LRO)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurations: 'specification/netapp/resource-manager/Microsoft.NetApp/NetApp/tspconfig.yaml', SDK Release Type: stable, and CommitSHA: '9280f5a9adfdf0cc051f59f5ade2b2642dc1b472' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6412798 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=2270 Submitted by: b-aubald@microsoft.com