App Config Spring - Snapshot references#49414
Open
mrm9084 wants to merge 7 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds first-class support for Snapshot Reference settings in the Spring Cloud Azure App Configuration config module, including tracing/telemetry updates and tests to validate reference resolution and feature flag behavior when snapshots are involved.
Changes:
- Resolve snapshot reference settings by fetching the referenced snapshot and loading its settings as properties.
- Extend request correlation/tracing to include a new
SnapshotReffeature tag. - Update property source construction to pass a
FeatureFlagClient, and add/adjust tests and changelog entry for the new behavior.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/spring/spring-cloud-azure-appconfiguration-config/src/main/java/com/azure/spring/cloud/appconfiguration/config/implementation/AppConfigurationApplicationSettingPropertySource.java | Adds snapshot reference resolution and integrates feature flag processing for snapshot-derived feature flags. |
| sdk/spring/spring-cloud-azure-appconfiguration-config/src/main/java/com/azure/spring/cloud/appconfiguration/config/implementation/AppConfigurationSnapshotPropertySource.java | Refactors snapshot property loading path to process settings locally and then process feature flags. |
| sdk/spring/spring-cloud-azure-appconfiguration-config/src/main/java/com/azure/spring/cloud/appconfiguration/config/implementation/AzureAppConfigDataLoader.java | Wires FeatureFlagClient into application setting property source creation. |
| sdk/spring/spring-cloud-azure-appconfiguration-config/src/main/java/com/azure/spring/cloud/appconfiguration/config/implementation/http/policy/TracingInfo.java | Adds snapshot reference usage tracking and emits SnapshotRef in the Features correlation context. |
| sdk/spring/spring-cloud-azure-appconfiguration-config/src/main/java/com/azure/spring/cloud/appconfiguration/config/implementation/AppConfigurationConstants.java | Introduces SNAPSHOT_REFERENCE_TAG constant for tracing output. |
| sdk/spring/spring-cloud-azure-appconfiguration-config/src/test/java/com/azure/spring/cloud/appconfiguration/config/implementation/http/policy/TracingInfoTest.java | Adds/updates tracing tests to validate SnapshotRef feature tagging. |
| sdk/spring/spring-cloud-azure-appconfiguration-config/src/test/java/com/azure/spring/cloud/appconfiguration/config/implementation/AppConfigurationApplicationSettingPropertySourceTest.java | Adds tests covering snapshot reference resolution and feature flag handling through snapshots. |
| sdk/spring/spring-cloud-azure-appconfiguration-config/src/test/java/com/azure/spring/cloud/appconfiguration/config/implementation/AppConfigurationPropertySourceKeyVaultTest.java | Updates test setup for the new property source constructor signature. |
| sdk/spring/spring-cloud-azure-appconfiguration-config/CHANGELOG.md | Documents the new snapshot reference support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for Snapshot References
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines