feat: introduce asynchronous nodepool creation in backend in a disabled state#5790
Merged
openshift-merge-bot[bot] merged 1 commit intoJun 30, 2026
Conversation
Collaborator
|
/lgtm |
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces backend support for asynchronous node pool creation by adding a controller that can “adopt or create” a Cluster Service node pool and persist its ClusterServiceID onto the NodePool Cosmos document, while updating the node pool create operation controller to read the ClusterServiceID from the NodePool resource (rather than relying on the operation’s InternalID).
Changes:
- Add a NodePool → Cluster Service create/adoption controller that POSTs the node pool when missing and then writes the resulting ClusterServiceID back to Cosmos.
- Update the node pool create operation controller to drive operation status updates off the NodePool Cosmos document (listers + ClusterServiceID from the resource).
- Expand tests and adjust test fixtures to use the ARO-HCP node pool href format.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| backend/pkg/controllers/operationcontrollers/utils.go | Removes legacy shared polling helper for node pool operations. |
| backend/pkg/controllers/operationcontrollers/test_helpers_test.go | Updates node pool internal ID fixture to ARO-HCP node pool href format. |
| backend/pkg/controllers/operationcontrollers/operation_node_pool_create.go | Switches to listers and NodePool-backed ClusterServiceID for status polling and operation updates. |
| backend/pkg/controllers/operationcontrollers/operation_node_pool_create_test.go | Updates/extends operation-node-pool-create unit tests for new reconciliation gating and lister usage. |
| backend/pkg/controllers/nodepoolcreationcontrollers/node_pool_cluster_service_create_controller.go | Adds controller to create/adopt CS node pools and persist ClusterServiceID onto NodePool Cosmos documents. |
| backend/pkg/controllers/nodepoolcreationcontrollers/node_pool_cluster_service_create_controller_test.go | Adds unit tests covering create/adopt flows and error propagation. |
| backend/pkg/app/backend.go | Wires the new controller into backend controller startup and updates controller construction dependencies. |
Comment on lines
+146
to
+152
| var persistErr *arm.CloudErrorBody | ||
| if operationalState.provisioningState == arm.ProvisioningStateFailed { | ||
| persistErr = &arm.CloudErrorBody{ | ||
| Code: arm.CloudErrorCodeInvalidRequestContent, | ||
| Message: operationalState.message, | ||
| } | ||
| } |
miguelsorianod
force-pushed
the
move-cs-nodepoolcreation-to-backend-1
branch
from
7f84a38 to
c851f60
Compare
Collaborator
|
/lgtm |
Collaborator
Author
|
/hold until we discuss the handling of the code to be returned in the operation. |
miguelsorianod
force-pushed
the
move-cs-nodepoolcreation-to-backend-1
branch
from
20868b4 to
b774f30
Compare
deads2k
reviewed
Jun 26, 2026
deads2k
reviewed
Jun 26, 2026
miguelsorianod
force-pushed
the
move-cs-nodepoolcreation-to-backend-1
branch
from
b774f30 to
240f08d
Compare
Collaborator
|
/lgtm |
Comment on lines
+146
to
+152
| var persistErr *arm.CloudErrorBody | ||
| if operationalState.provisioningState == arm.ProvisioningStateFailed { | ||
| persistErr = &arm.CloudErrorBody{ | ||
| Code: arm.CloudErrorCodeInvalidRequestContent, | ||
| Message: operationalState.message, | ||
| } | ||
| } |
miguelsorianod
force-pushed
the
move-cs-nodepoolcreation-to-backend-1
branch
from
240f08d to
d27249c
Compare
Collaborator
|
/lgtm |
miguelsorianod
force-pushed
the
move-cs-nodepoolcreation-to-backend-1
branch
from
d27249c to
f387bbc
Compare
…ed state The backend logic to perform asynchronous nodepool creation is disabled for now: the added controller is only executed when ClusterServiceID is not set. For now in frontend we always store the ClusterServiceID so it is guaranteed to not be executed. Additionally, the nodepool create operation has been updated to retrieve the ClusterServiceID from the NodePool cosmos resource instead of the operation. This allows us to stop relying on it for when we stop setting it in frontend.
miguelsorianod
force-pushed
the
move-cs-nodepoolcreation-to-backend-1
branch
from
f387bbc to
fd620eb
Compare
Collaborator
Author
|
/hold cancel |
Collaborator
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, miguelsorianod The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
Author
|
/retest |
Contributor
Contributor
stevekuznetsov
added a commit
that referenced
this pull request
Jun 30, 2026
Revert "Merge pull request #5790 from miguelsorianod/move-cs-nodepool-creation-to-backend-1
miguelsorianod
added a commit
to miguelsorianod/ARO-HCP
that referenced
this pull request
Jun 30, 2026
…depoolcreation-to-backend-1" This reverts commit 0666787, effectively reverting the revert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backend logic to perform asynchronous nodepool creation is disabled for now: the added controller is only executed when ClusterServiceID is not set. For now in frontend we always store the ClusterServiceID so it is guaranteed to not be executed.
Additionally, the nodepool create operation has been updated to retrieve the ClusterServiceID from the NodePool cosmos resource instead of the operation. This allows us to stop relying on it for when we stop setting it in frontend.