refactor: DI/repository pattern and remove legacy UnitOfWork (#37)#142
Open
VECTORG99 wants to merge 1 commit into
Open
refactor: DI/repository pattern and remove legacy UnitOfWork (#37)#142VECTORG99 wants to merge 1 commit into
VECTORG99 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DI / Repository Pattern (#37)
Changes
api/repositories.py(NEW) — SQL Repository base class + concreteGoalRepository,ProgressRepository,ContentRepositorywith automatic session managementapi/services/embedding_service.py— UsesContentRepositoryinstead of direct session queries, acceptsSessionvia dependency injectionapi/services/goal_service.py— UsesGoalRepository,ProgressRepositoryfor persistenceapi/services/gamification_engine.py— UsesGoalRepository,ProgressRepositoryvia constructor injectionapi/services/github_service.py— MakesAsyncSessionexplicit (session: AsyncSession = Depends(get_session))api/services/skill_tree.py— UsesContentRepositoryfor DB accessapi/services/tag_graph.py— UsesContentRepositoryfor DB accessapi/services/personal_streak_service.py— UsesContentRepositoryfor DB accessapi/services/unit_of_work.py(DELETED) — Legacy UoW replaced by explicit repo injectionCloses #37