DankKDEConnect: fix last device clipped in control center detail#75
Open
kanghengliu wants to merge 1 commit into
Open
DankKDEConnect: fix last device clipped in control center detail#75kanghengliu wants to merge 1 commit into
kanghengliu wants to merge 1 commit into
Conversation
The control center host sizes the plugin detail panel to ccDetailHeight (350) minus spacing, but KDEConnectDetailContent used a hardcoded 300px list area below a header, divider, and margins. The combined height overflowed the allocated panel, clipping the bottom of the last device entry and making it unclickable when scrolled to the bottom. Size the list area from the rectangle's actual height (driven by the host loader) instead of a fixed value, and drop the now-unused listHeight property. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The control center host sizes the plugin detail panel to ccDetailHeight (350) minus spacing, but KDEConnectDetailContent used a hardcoded 300px list area below a header, divider, and margins. The combined height overflowed the allocated panel, clipping the bottom of the last device entry and making it unclickable when scrolled to the bottom.
Size the list area from the rectangle's actual height (driven by the host loader) instead of a fixed value, and drop the now-unused listHeight property.