Fix: cast $blog_id to int in wp_cache_clear_cache() to prevent crash on non-multisite installs#1042
Open
DeveloperBatuhanALGUL wants to merge 1 commit into
Conversation
…ite function calls on single-site installs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a third-party theme or plugin calls
wp_cache_clear_cache('all', false)with a non-integer$blog_id, the function passes that value directly toget_supercache_dir(), which internally callsget_blog_option()— a multisite-only function. On non-multisite installs, this causes a fatal error.Fixes #1019
Fix
Cast
$blog_idtointat the top of the function. This ensures any non-integer value (e.g.'all',false) is normalized to0, which correctly triggers the single-site cache clearing path.Testing
wp_cache_clear_cache('all', false)