[RSM] Smart bookmarks bottom sheet#5285
Open
sztomek wants to merge 6 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a dedicated “Bookmark details” bottom sheet so users can tap a bookmark row (when not multi-selecting) to view its full details (title, episode title, timestamp, AI summary, created-at) and play/pause from that sheet.
Changes:
- Updated bookmark row tap handling to open a bookmark detail flow when multi-select is not active.
- Wired a new navigation event from
BookmarksViewModel→BookmarksPage→BookmarksFragmentto presentBookmarkDetailFragment. - Added a new Compose UI (
BookmarkDetailPage) and dialog fragment (BookmarkDetailFragment) for the bottom sheet content.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/features/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/viewmodel/BookmarksViewModel.kt | Emits a new showBookmarkDetail event on row tap when not multi-selecting. |
| modules/features/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/view/bookmark/BookmarksPage.kt | Collects the new event and forwards it to a UI callback with episode title context. |
| modules/features/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/view/bookmark/BookmarksFragment.kt | Shows BookmarkDetailFragment when the detail-click callback fires. |
| modules/features/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/view/bookmark/BookmarkDetailPage.kt | New Compose UI rendering bookmark detail content and playback controls. |
| modules/features/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/view/bookmark/BookmarkDetailFragment.kt | New dialog fragment hosting the detail page in a bottom-sheet style dialog. |
Collaborator
|
Version |
55703ec to
68a455d
Compare
3aea6fd to
d7821b5
Compare
68a455d to
b906b00
Compare
d7821b5 to
1e41256
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is the last piece of the puzzle as we can now display all the bookmark details on a dedicated bottom sheet.
Testing Instructions
Since the server changes are not deployed yet, please refer to #5284 for test instructions
Screenshots or Screencast
Checklist
./gradlew spotlessApplyto automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xml