Skip to content

[RSM] Smart bookmarks bottom sheet#5285

Open
sztomek wants to merge 6 commits into
feat/smart-bookmarks-uifrom
feat/smart-bookmark-details-bottomsheet
Open

[RSM] Smart bookmarks bottom sheet#5285
sztomek wants to merge 6 commits into
feat/smart-bookmarks-uifrom
feat/smart-bookmark-details-bottomsheet

Conversation

@sztomek
Copy link
Copy Markdown
Contributor

@sztomek sztomek commented May 8, 2026

Description

This PR is the last piece of the puzzle as we can now display all the bookmark details on a dedicated bottom sheet.

Testing Instructions

Since the server changes are not deployed yet, please refer to #5284 for test instructions

Screenshots or Screencast

Screenshot_20260508_171057

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@sztomek sztomek added this to the 8.12 milestone May 8, 2026
@sztomek sztomek requested a review from a team as a code owner May 8, 2026 15:18
@sztomek sztomek requested review from Copilot and geekygecko and removed request for a team May 8, 2026 15:18
@sztomek sztomek added [Type] Feature Adding a new feature. [Area] Bookmarks labels May 8, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a dedicated “Bookmark details” bottom sheet so users can tap a bookmark row (when not multi-selecting) to view its full details (title, episode title, timestamp, AI summary, created-at) and play/pause from that sheet.

Changes:

  • Updated bookmark row tap handling to open a bookmark detail flow when multi-select is not active.
  • Wired a new navigation event from BookmarksViewModelBookmarksPageBookmarksFragment to present BookmarkDetailFragment.
  • Added a new Compose UI (BookmarkDetailPage) and dialog fragment (BookmarkDetailFragment) for the bottom sheet content.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
modules/features/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/viewmodel/BookmarksViewModel.kt Emits a new showBookmarkDetail event on row tap when not multi-selecting.
modules/features/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/view/bookmark/BookmarksPage.kt Collects the new event and forwards it to a UI callback with episode title context.
modules/features/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/view/bookmark/BookmarksFragment.kt Shows BookmarkDetailFragment when the detail-click callback fires.
modules/features/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/view/bookmark/BookmarkDetailPage.kt New Compose UI rendering bookmark detail content and playback controls.
modules/features/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/view/bookmark/BookmarkDetailFragment.kt New dialog fragment hosting the detail page in a bottom-sheet style dialog.

@wpmobilebot wpmobilebot modified the milestones: 8.12, 8.13 May 11, 2026
@wpmobilebot
Copy link
Copy Markdown
Collaborator

Version 8.12 has now entered code-freeze, so the milestone of this PR has been updated to 8.13.

@sztomek sztomek force-pushed the feat/smart-bookmarks-ui branch from 55703ec to 68a455d Compare May 11, 2026 19:36
@sztomek sztomek force-pushed the feat/smart-bookmark-details-bottomsheet branch from 3aea6fd to d7821b5 Compare May 11, 2026 19:37
@sztomek sztomek force-pushed the feat/smart-bookmarks-ui branch from 68a455d to b906b00 Compare May 11, 2026 19:44
@sztomek sztomek force-pushed the feat/smart-bookmark-details-bottomsheet branch from d7821b5 to 1e41256 Compare May 11, 2026 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants