fix(parse.ly): update meta_type default#4724
Open
chickenn00dle wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Newspack’s automated configuration defaults for the Parse.ly plugin to use Parse.ly’s recommended meta_type setting (repeated_metas), intended to avoid the Yoast conflict referenced in NPPM-2833.
Changes:
- Change the default Parse.ly setting
meta_typefromjson_ldtorepeated_metaswhen Newspack initializes Parse.ly settings for the first time.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Just noting the lint failure was fixed here in trunk: #4718 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Closes https://linear.app/a8c/issue/NPPM-2833/possible-conflict-between-yoast-and-our-required-parsely-code-that-may
This PR updates the default meta_type parse.ly config to
repeated_metaswhich is recommended by parse.ly . This also implements a migrator so existing sites with Parse.ly get the updated setting.We need to do this to avoid the conflict pointed out in the linear task above when Yoast is active.
Removing parsely
These tests will require removing parsely and parsely settings several times. You can do so with the following:
release, add the following snippet to a site where parsely is removed:repeated_metasrepeated_metasOther information: