Skip to content

fix(parse.ly): update meta_type default#4724

Open
chickenn00dle wants to merge 2 commits into
releasefrom
fix/update-default-parsely-config
Open

fix(parse.ly): update meta_type default#4724
chickenn00dle wants to merge 2 commits into
releasefrom
fix/update-default-parsely-config

Conversation

@chickenn00dle
Copy link
Copy Markdown
Contributor

@chickenn00dle chickenn00dle commented May 13, 2026

All Submissions:

Changes proposed in this Pull Request:

Closes https://linear.app/a8c/issue/NPPM-2833/possible-conflict-between-yoast-and-our-required-parsely-code-that-may

This PR updates the default meta_type parse.ly config to repeated_metas which is recommended by parse.ly . This also implements a migrator so existing sites with Parse.ly get the updated setting.

We need to do this to avoid the conflict pointed out in the linear task above when Yoast is active.

Removing parsely
These tests will require removing parsely and parsely settings several times. You can do so with the following:

wp plugin delete wp-parsely
wp option delete parsely
  1. On release, add the following snippet to a site where parsely is removed:
add_action( 'init', function(){
	$request = new WP_REST_Request( 'POST', '/newspack/v1/plugins/wp-parsely/configure' );
	$response = rest_do_request( $request );
} );
  1. Reload the page and go to Parsely settings.
  2. Confirm you see json_ld selected for Metadata Format:
Screenshot 2026-05-14 at 09 41 25
  1. Checkout this branch and reload the page
  2. Confirm Metadata Format is now set to repeated_metas
  3. Now remove parsely once again
  4. Ensure the snippet from step 1 is still present, then reload the page. (You'll likely need to navigate away and back again to the parsely settings page if you removed following the steps above)
  5. Confirm Metadata Format is set to repeated_metas

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copilot AI review requested due to automatic review settings May 13, 2026 19:42
@chickenn00dle chickenn00dle requested a review from a team as a code owner May 13, 2026 19:42
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Newspack’s automated configuration defaults for the Parse.ly plugin to use Parse.ly’s recommended meta_type setting (repeated_metas), intended to avoid the Yoast conflict referenced in NPPM-2833.

Changes:

  • Change the default Parse.ly setting meta_type from json_ld to repeated_metas when Newspack initializes Parse.ly settings for the first time.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@chickenn00dle
Copy link
Copy Markdown
Contributor Author

Just noting the lint failure was fixed here in trunk: #4718

@chickenn00dle chickenn00dle added the [Status] Needs Review The issue or pull request needs to be reviewed label May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Needs Review The issue or pull request needs to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants