fix: prevent content-gate editor.scss styles from getting chunked into the common.css file#4716
Open
laurelfulford wants to merge 3 commits into
Open
fix: prevent content-gate editor.scss styles from getting chunked into the common.css file#4716laurelfulford wants to merge 3 commits into
laurelfulford wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses unintended Gutenberg component styling bleed caused by editor.scss being imported by multiple entrypoints and ending up in a shared/common stylesheet chunk. It isolates the block visibility panel styles into a dedicated stylesheet and tweaks the generic BaseControl margin rule to avoid impacting the publish-date time UI.
Changes:
- Switched
block-visibility.tsxto import a newblock-visibility.scssinstead ofeditor.scss, preventingeditor.scssfrom being pulled into a common chunk. - Extracted the block visibility panel SCSS from
editor.scssinto the newblock-visibility.scss. - Adjusted
.components-base-controlspacing ineditor.scssto exclude DateTime/time-wrapper controls.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/content-gate/editor/editor.scss |
Removes now-unneeded WP variables import, updates BaseControl margin behavior, and removes block-visibility panel styles (moved out). |
src/content-gate/editor/block-visibility.tsx |
Stops importing editor.scss and imports the new, dedicated block-visibility stylesheet. |
src/content-gate/editor/block-visibility.scss |
New isolated styles for the Access Control block visibility panel. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This one was weird!
In #4646, a new file
block-visibility.tsxstarted importingcontent-gate/editor.scss. Newspack Plugin's Webpack hasminChunks: 2; since this was the second file editor.css was imported into, it started getting included in the common.css, which caused the.components-base-controlstyles in that CSS file to bleed into more post types.The
.components-base-controlstyle wasn't very specific, but this only started being an issue when the styles were imported into more editors.This PR does two things:
.components-base-controlstyles more specific (adding content gate-specific CSS classes) since this issue was still happening when you edited a Content Gate.Closes NPPM-2812
How to test the changes in this Pull Request:
npm run build; refresh the post editor and confirm the date picker looks okay.define( 'NEWSPACK_CONTENT_GATES', true );to your wp-config.php, and set up a content gate).Other information: