Skip to content

perf: use kareem 3.3.0 re: mongoosejs/kareem#45 - #16229

Merged
vkarpov15 merged 4 commits into
masterfrom
vkarpov15/kareem-3.3
Apr 16, 2026
Merged

vkarpov15 merged 4 commits into
masterfrom
vkarpov15/kareem-3.3

Conversation

@vkarpov15

Copy link
Copy Markdown
Collaborator

Summary

Pulling in changes from mongoosejs/kareem#45 - consistently trims 5-10% off of the saveSimple benchmark. Not a lot, but we're getting much closer to matching the MongoDB Node driver.

Before:

{
  "Average mongoose save time ms": 1.03,
  "Average driver insertOne time ms": 0.71
}

After:

{
  "Average mongoose save time ms": 0.98,
  "Average driver insertOne time ms": 0.73
}

Examples

@vkarpov15 vkarpov15 added this to the 9.5 milestone Apr 14, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Mongoose’s Kareem dependency to pull in upstream performance improvements (mongoosejs/kareem#45), aiming to reduce overhead in common save flows and improve benchmark parity with the MongoDB Node driver.

Changes:

  • Bump kareem dependency from 3.2.0 to 3.3.0.

@hasezoey hasezoey left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from some CI failing likely due to outdated github npm cache on some runners (notarget kareem@3.3.0), this LGTM.

Comment thread package.json
@vkarpov15
vkarpov15 merged commit 5800081 into master Apr 16, 2026
51 of 52 checks passed
@vkarpov15
vkarpov15 deleted the vkarpov15/kareem-3.3 branch April 16, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants