Repository navigation
feat(mobile): comment markers and bubbles on the Now Playing scrubber - #14702
Merged
Merged
Conversation
Timestamped comments show up in the player without opening the drawer, the way SoundCloud does it. Each one is a dot above the scrubber rail, and when playback reaches it the comment appears as a pill under the scrubber for six seconds: avatar, name, first line. Tapping the pill opens the comment drawer with that comment highlighted. Behind now_playing_comments (default on). Comments load with the timestamp sort, one page of 50, only while the drawer is open. Position is polled from the native player twice a second while playing. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2 of the redesign spec, the SoundCloud-style piece: timestamped comments show up in the player as playback reaches them, without opening the comments drawer.
What it does
now_playing_comments, default on in code (same pattern astrack_rows), so RC picks it up on merge; the remote flag is the kill switch.How
useTimestampedComments:useTrackCommentswith thetimestampsort, one page of 50, enabled only while the drawer is open (the list query hasgcTime: 0), filtered to comments with a timestamp.CommentBubble: zero-height in the layout, the pill floats in the 40px gap above the controls. Position is polled fromTrackPlayer.getProgress()twice a second while the drawer is open and playing, plus the redux seek.Slidergets amarkersprop (0 to 1 fractions) threaded throughScrubber.Tested on the iOS 26.5 simulator (1.5.190 Release build with this bundle swapped in, signed in) on a track with five timestamped comments: markers at the right positions, the bubble at 0:08 and 0:28, tap opens the drawer on that comment, seek updates the bubble. Mobile
tscand eslint clean. Not tested: Android, long-form content at non-1x playback rate (the bubble follows the native position, so it should be correct), VoiceOver.Not in this PR: the comment count next to the comments button, the artwork-tinted player background, and the web play bar ticks from the same spec section.
🤖 Generated with Claude Code