Skip to content

Wire Syndicate action card resolve button - #5537

Merged
wholton merged 1 commit into
masterfrom
fix-syndicate-resolve-button
Aug 15, 2026
Merged

Wire Syndicate action card resolve button#5537
wholton merged 1 commit into
masterfrom
fix-syndicate-resolve-button

Conversation

@wholton

@wholton wholton commented Aug 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • SyndicateAcd2ButtonHandler defines @ButtonHandler("resolveSyndicate"), but ActionCardHelper had no branch for automationID = "syndicate", so playing the card never emitted its resolve button. This wires up the button next to the other acd2 cards (e.g. ubiquity).

Why

  • Every other automated action card is wired up via an if ("<automationID>".equals(automationID)) block in ActionCardHelper.playAsAction. Syndicate slipped through — the handler shipped without a corresponding emission site, so Play Syndicate produced no follow-up button.

Scope check

  • I audited every acd2 card. This is the only card where a handler exists but no play-time button is emitted. Riders (classified_rider, defense_rider) and amendment correctly emit from AgendaHelper / StartPhaseService per their windows. The rest of the missing IDs have no handler code at all (out of scope for this fix).

Test plan

  • Play Syndicate as an action; a Resolve Syndicate button appears.
  • Pressing it reveals N cards (N = real player count) and produces per-player assign buttons.
  • Assigning cards routes each to the target player and clears state when done.

🤖 Generated with Claude Code

SyndicateAcd2ButtonHandler defined @ButtonHandler("resolveSyndicate")
but ActionCardHelper never emitted the button on play, so the card
could be played without any way to resolve it.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

🔬 Test Results

✅ JSON Validation

No JSON files changed.


✅ Formatting Checks Passed

All files pass Spotless formatting.


✅ JUnit Tests Passed

All tests passed successfully.

@wholton
wholton merged commit bdf5561 into master Aug 15, 2026
3 checks passed
@wholton
wholton deleted the fix-syndicate-resolve-button branch August 15, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant