Wire Syndicate action card resolve button - #5537
Merged
Merged
Conversation
SyndicateAcd2ButtonHandler defined @ButtonHandler("resolveSyndicate")
but ActionCardHelper never emitted the button on play, so the card
could be played without any way to resolve it.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
🔬 Test Results✅ JSON ValidationNo JSON files changed. ✅ Formatting Checks PassedAll files pass Spotless formatting. ✅ JUnit Tests PassedAll tests passed successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SyndicateAcd2ButtonHandlerdefines@ButtonHandler("resolveSyndicate"), butActionCardHelperhad no branch forautomationID = "syndicate", so playing the card never emitted its resolve button. This wires up the button next to the other acd2 cards (e.g.ubiquity).Why
if ("<automationID>".equals(automationID))block inActionCardHelper.playAsAction. Syndicate slipped through — the handler shipped without a corresponding emission site, soPlay Syndicateproduced no follow-up button.Scope check
acd2card. This is the only card where a handler exists but no play-time button is emitted. Riders (classified_rider,defense_rider) andamendmentcorrectly emit fromAgendaHelper/StartPhaseServiceper their windows. The rest of the missing IDs have no handler code at all (out of scope for this fix).Test plan
🤖 Generated with Claude Code