Color deficient color/hue guards - #5501
Open
Stabar-ti wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resoning:
From personal history I tried to implement the following accessibility improvement:
Color deficient:
in the submitted PR I added a setting for players to set if they are color deficient (False by default), RED-GREEN, other. (in relative anon)
Only if such a green-red player is in a game:
In case of RED GREEN (8% of the male population) automated color assignment tries to make sure hue and color are correctly assigned.
When SO are dealt the colors are checked one more time to see if there are issues and asks the players to change it
When people change their color through command the check is again performed
It will advice people to also set a decal.
This check is only performed during color change and start of the game
When an "other" player is in the game. It requests all players on behalf of the async staff to set a decal. (These colors are way more rare 1/1000)
This should remove the need to have a person publicly announce that they are color deficient. (Of course it is 1 or more of the 6 players)
Some Core files and functions were touched. So I prefer a second eye on those changes
IMPLEMENTATION:
Core formulas written by me
Assisted fixes by claude
code comments flashed out by claude
TESTS:
review manually all changes
review by GPT5.6 / codex
Written Tests for regression
Tested functionality LIVE n FOG and normal games (Left rematch out on purpose)