Repository navigation
Conversation
Previous review (2026-11-09)Automated review note — AI-generated (Claude+Codex), validated against the live diff. Please sanity-check before acting. Reviewed at head The step-response stats table works and gives correct values for the default 400 Hz / 512-sample case, but there are two edge cases where it shows misleading numbers. Should fix
Minor (1)
|
Previous review (2026-11-09)Automated review note — AI-generated (Claude+Codex), validated against the live diff. Please sanity-check before acting. Reviewed at head The step-response stats table now looks good to merge at head 9eae3fe, with no open findings. All three earlier findings are fixed. Short estimates (under 0.4 s) no longer produce a row, switching to an axis without an FFT clears the table, and unticked tests drop out of the table. Two new concerns were checked and dropped as pre-existing behaviour rather than this PR. After a Scale or Calculate redraw, unticked mean lines come back on the plot, because redraw_step() forces them visible at PIDReview/PIDReview.js:1323. A failed recalculation leaves the step plot stale, and the table matches that stale plot. |
|
Done: times are in seconds, peak and final value are a percentage of the step, and the table is under the plot. The missing overshoot was the rule that left it blank when the peak was in the final value window (0.2 to 0.4 s), both your peaks were in there. It's now shown whenever the peak is above the final value, except a peak right at 0.4 s, where the response is still rising, which shows 0%. |
Previous review (2026-11-20)Automated review note — AI-generated (Claude+Codex), validated against the live diff. Please sanity-check before acting. Reviewed at head The stats table is in good shape at head 97b3890, with one minor overshoot edge case left. Since the last review (9eae3fe), the table has moved below the plot. Times now show in seconds, and peak and final value as percentages. A peak inside the final window (Test 2 in the screenshot) now gets an overshoot value. Minor (1)
|
Previous review (2026-11-20)Automated review note — AI-generated (Claude+Codex), validated against the live diff. Please sanity-check before acting. Reviewed at head One overshoot issue is left at head 2571c2d, and it was introduced by the fix for the last one. Since the last review (97b3890), the overshoot no longer flips when the last sample is a little below the peak. Should fix
|
Previous review (2026-11-21)Automated review note — AI-generated (Claude+Codex), validated against the live diff. Please sanity-check before acting. Reviewed at head The step-response stats table looks good to merge at head 0839900, with no open findings. Since the last review (2571c2d), the still-rising check also requires the peak to be at the end of the window. A small early overshoot followed by a creeping tail, or a sustained oscillation, now shows its overshoot again, while responses that are still rising stay at 0 %. |
…icked tests No stats when the estimate is shorter than the 0.4 s window, clear the table when the axis data is set up, and leave out tests that are unticked.
Times are in seconds to match the plot and peak and final value are a percentage of the step. Overshoot is shown whenever the peak is above the final value, unless the peak is at the end of the measured range, where the response is still rising. The table is now under the plot.
Rather than whether the last sample is the peak, which flipped the overshoot between 0 and the full value on a tiny difference.
…s at the end A small early overshoot with a tail that creeps up showed 0%.
0839900 to
0afb8e5
Compare
|
rebased onto master and kept your step note below the table, and added some space above the table |
|
Automated review note — AI-generated (Claude+Codex), validated against the live diff. Please sanity-check before acting. Reviewed at head The step-response stats table looks good to merge at head 0afb8e5, with no open findings. Since the last review (0839900), the PR has been rebased onto main, so the merge conflicts are gone, and the table now has a 1em gap below the plot as requested. The stats code is unchanged, and the peak-location fix for overshoot still holds. |


"Settling time read out. also other stats overshoot ect." from #92.
A table under the Step Response plot gives, for the mean response of each test: rise time (10 to 90%), peak and peak time, overshoot, settling time (5% band) and final value. Times are in seconds to match the plot, peak and final value are a percentage of the step.
The calculation matches an independent Python version on three analytic second order responses (damping 0.3/0.5/0.8). For damping 0.5 it gives 16.4% overshoot with the peak at 90 ms, against theory's 16.3% at 90.7 ms. The thresholds (
step_stats_*) are easy to change if you'd prefer other definitions. No change to the step estimate itself.