Repository navigation
Conversation
Previous review (2026-11-09)Automated review note — AI-generated (Claude+Codex), validated against the live diff. Please sanity-check before acting. Reviewed at head The Show estimated hint works as intended for the Recalculate filters button; three small nonblocking follow-ups remain. Suggestions
Minor (2)
|
Show the hint after loading parameters or changing filter version too, only offer estimates for gyros with pre-filter data, and redraw once when showing them.
Previous review (2026-11-09)Automated review note — AI-generated (Claude+Codex), validated against the live diff. Please sanity-check before acting. Reviewed at head No remaining issues found at head 6aa6b1d: the Show estimated hint works for Recalculate filters, Load Parameters and the filter-version radios. Since the last review (at e50cb8f), all three earlier suggestions are fixed. Load Parameters and the version radios now go through |
|
How do you feel about just automatically showing the estimated after recalculate is hit? If there is already a estimated selected then don't change anything. If there is no estimated then mirror the axis that the user has selected with the logged post filter. If there are none selected at the end then just show all. |
Rather than prompting, recalculating filters shows the estimated post-filter if none is shown: for the axes the logged post-filter is shown for, or all if that is none.
|
Done, it now shows the estimate automatically after recalculating: nothing changes if one is already shown, otherwise it mirrors the shown post-filter axes, or shows all if none are. |
Previous review (2026-11-20)Automated review note — AI-generated (Claude+Codex), validated against the live diff. Please sanity-check before acting. Reviewed at head No issues found at head 3bf09a8: the estimated post-filter now shows automatically after Recalculate filters, Load Parameters and the filter-version radios, as IamPete1 asked. Since the last review (at 6aa6b1d), the Show estimated hint has been replaced by automatic display. An estimate that is already shown is left alone; otherwise the estimate mirrors the logged post-filter axes, or shows all of them. The three earlier fixes still hold. |
|
fixed, it only turns on the estimate for IMUs with some pre-filter selected now |
|
Automated review note — AI-generated (Claude+Codex), validated against the live diff. Please sanity-check before acting. Reviewed at head No issues found at head a2ee02d: the estimated post-filter still shows automatically after Recalculate filters, Load Parameters and the filter-version radios, and an estimate that is already shown is left alone. Since the last review (at 3bf09a8), The previous review's "no issues" call at 3bf09a8 missed that case; it is now fixed. |

"Prompt to select estimated post filter if not shown and filter param change is done" from #10.
After recalculating filters, the estimated post-filter is shown if no estimate is shown yet:
This runs on Recalculate filters, on loading a param file and on changing the filter version, all of which change the estimate. Loading a log doesn't change what is shown.
Checked on a batch log: estimates mirror the shown post-filter axes after a recalculate, a manually chosen estimate is left alone, all axes are shown when no post-filter is selected, and gyros with no pre-filter shown are left alone.