Update satisfactory trigger to use intermediate value#403
Open
adamsong wants to merge 1 commit into
Open
Conversation
Contributor
|
I approve this, i did try the yaml triggers, and they seem to work fine now |
Jarno458
approved these changes
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Archipelago runs
get_choiceit will check if there is a randomization, and roll it. When one of the goal triggers was settinggoal_selectionit was setting it to an array, which if there was another goal triggers, would be randomly pulled from. Adding the dummy option ofgoal_selection_for_triggerallowed setting a weighted value that the triggers can act on to write togoal_selectionand allow setting it to an array without that array being randomized.I tested this, and all 4 possible goal options show up as the correct goal in the spoiler log, and successfully generate.