fix(cli): honor saved coordinator host by adity982 · Pull Request #898 · ArcadeAI/arcade-mcp

adity982 · 2026-07-22T06:12:51Z

Summary

Organization and project commands now use the coordinator URL saved by arcade login when no connection flags are provided, matching the behavior of the rest of the CLI. Explicit host, port, and TLS flags continue to take precedence.

Resolves: #896

Design decisions

The fallback is centralized in resolve_coordinator_url so both command groups share the same precedence rules. The visible --host default remains the production coordinator for help output, while None internally distinguishes an omitted flag from an explicit override.

Test plan

uv run pytest libs/tests/cli/test_org_project.py (3 passed)
uv run ruff check for the changed Python files
uv run ruff format --check for the changed Python files

Author checklist

Before moving this PR from Draft to Ready for Review:

Linked to a GitHub issue (above)
I understand every change in the diff
Runs locally, exercised through the end-user path (not just unit tests)
make check and make test are green locally; CI is expected to pass
I've reviewed my own diff top-to-bottom
I'd merge it myself if a teammate said LGTM right now

Note

Low Risk
Localized CLI connection resolution with clear precedence rules and unit tests; no auth or server-side behavior changes.

Overview
arcade org and arcade project now use the coordinator URL from login config when you don't pass --host, --port, or TLS flags—instead of always targeting production.

A shared resolve_coordinator_url helper implements precedence: saved coordinator_url from config when all connection options are omitted; otherwise compute_base_url with explicit flags (e.g. --host still overrides the saved URL). --host defaults to None internally so "not passed" is distinguishable from an override, while help still shows the production host via show_default.

CLI tests cover saved URL usage, explicit host override, and production fallback when config is missing.

^{Reviewed by Cursor Bugbot for commit b04ae23. Bugbot is set up for automated code reviews on this repo. Configure here.}

cursor

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit 5daa4a2. Configure here.}

codecov · 2026-07-26T19:46:37Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines	Coverage Δ
libs/arcade-cli/arcade_cli/org.py	`34.84% <100.00%> (+13.95%)`	⬆️
libs/arcade-cli/arcade_cli/project.py	`38.46% <100.00%> (+17.24%)`	⬆️
libs/arcade-cli/arcade_cli/utils.py	`57.98% <100.00%> (+0.93%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-actions · 2026-08-10T00:13:40Z

This pull request has been automatically marked as stale because it has had no activity for 14 days. It will be closed in 14 days if no further activity occurs. If this is still relevant, please leave a comment or remove the stale label.

…rdinator-host

adity982 · 2026-08-10T15:16:06Z

Addressed the missing-config review finding in commit 3aab68d and merged current upstream main.
esolve_coordinator_url now falls back to the production coordinator when no saved config exists, with a CLI regression covering the no-config path. Post-merge validation: 4 focused tests passed; Ruff lint/format and lockfile checks passed. The review thread is now automatically resolved/outdated on the new head.

EricGustin · 2026-08-13T00:44:22Z

@greptileai

greptile-apps · 2026-08-13T00:46:36Z

Greptile Summary

Organization and project commands now resolve their coordinator URL from saved login configuration when no connection flags are supplied, while retaining explicit-option and production fallbacks.

Adds a shared coordinator URL resolver.
Updates both command callbacks to distinguish omitted hosts from explicit overrides.
Adds tests for saved URLs, host overrides, and missing configuration.

Confidence Score: 4/5

The PR appears safe to merge after addressing the non-blocking configuration-error handling and required package version update.

The intended saved-host precedence is implemented consistently, but invalid existing configuration can now escape from callbacks as a traceback, and the repository-required library version increment is absent.

Files Needing Attention: libs/arcade-cli/arcade_cli/utils.py and pyproject.toml

Important Files Changed

Filename	Overview
libs/arcade-cli/arcade_cli/utils.py	Adds centralized saved-URL resolution, but non-missing configuration errors can escape from command callbacks.
libs/arcade-cli/arcade_cli/org.py	Changes the organization callback to distinguish an omitted host and delegate coordinator resolution.
libs/arcade-cli/arcade_cli/project.py	Applies the same coordinator-resolution behavior to project commands.
libs/tests/cli/test_org_project.py	Covers saved coordinator URLs, explicit host precedence, and production fallback, but not invalid configuration files.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Organization or project callback] --> B{Any connection flag supplied?}
    B -- Yes --> C[Build URL from explicit options and production host fallback]
    B -- No --> D[Load saved configuration]
    D --> E{Saved coordinator URL exists?}
    E -- Yes --> F[Use saved coordinator URL]
    E -- No or file missing --> G[Use production coordinator URL]

_{Reviews (1): Last reviewed commit: "Merge branch 'main' into agent/use-saved..." | Re-trigger Greptile}

greptile-apps · 2026-08-13T00:46:39Z

+            saved_url = Config.load_from_file().coordinator_url
+            if saved_url:
+                return saved_url
+        except FileNotFoundError:
+            pass
+


Handle invalid saved configuration

If the saved credentials file is malformed, structurally invalid, or unreadable, Config.load_from_file() raises an exception other than FileNotFoundError; because this now runs in the application callback, organization and project commands terminate with a traceback before their existing user-facing configuration handling runs.

greptile-apps · 2026-08-13T00:46:40Z

+def resolve_coordinator_url(
+    host: str | None,
+    port: int | None,
+    force_tls: bool,
+    force_no_tls: bool,
+) -> str:
+    """Resolve coordinator CLI options, falling back to the saved login host."""
+    if host is None and port is None and not force_tls and not force_no_tls:
+        from arcade_core.config_model import Config
+
+        try:
+            saved_url = Config.load_from_file().coordinator_url
+            if saved_url:
+                return saved_url
+        except FileNotFoundError:
+            pass
+
+    from arcade_core.constants import PROD_COORDINATOR_HOST
+
+    return compute_base_url(
+        force_tls,
+        force_no_tls,
+        host or PROD_COORDINATOR_HOST,
+        port,
+        default_port=None,
+    )


Version the CLI behavior change

This adds new arcade-cli behavior without increasing the version in pyproject.toml, so package consumers and release automation cannot distinguish the changed coordinator resolution behavior from the existing release.

Context Used: Guidelines for library versioning (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

EricGustin · 2026-08-13T00:54:10Z

+    force_no_tls: bool,
+) -> str:
+    """Resolve coordinator CLI options, falling back to the saved login host."""
+    if host is None and port is None and not force_tls and not force_no_tls:


suggestion: Gate on if host is None.

Assume the saved coodinator_url is https://coordinator.tenant.example.com

Then,

Command Resolves to

arcade org list https://coordinator.tenant.example.com correct

arcade org --host other.com list https://other.com correct

arcade org --port 8443 list https://cloud.arcade.dev:8443 wrong host

arcade org --tls list https://cloud.arcade.dev wrong host

arcade org --no-tls list http://cloud.arcade.dev wrong host

fix(cli): honor saved coordinator host

5daa4a2

evantahler requested review from EricGustin and samkujovich July 26, 2026 00:46

EricGustin marked this pull request as ready for review July 26, 2026 19:43

cursor Bot reviewed Jul 26, 2026

View reviewed changes

Comment thread libs/arcade-cli/arcade_cli/utils.py Outdated

github-actions Bot added the stale label Aug 10, 2026

adity982 added 2 commits August 10, 2026 20:42

fix(cli): fall back when login config is missing

3aab68d

Merge remote-tracking branch 'upstream/main' into agent/use-saved-coo…

206d301

…rdinator-host

github-actions Bot removed the stale label Aug 11, 2026

Merge branch 'main' into agent/use-saved-coordinator-host

b04ae23

greptile-apps Bot reviewed Aug 13, 2026

View reviewed changes

EricGustin reviewed Aug 13, 2026

View reviewed changes

Navigation Menu

Uh oh!

fix(cli): honor saved coordinator host - #898

fix(cli): honor saved coordinator host#898
adity982 wants to merge 4 commits into
ArcadeAI:mainfrom
adity982:agent/use-saved-coordinator-host

adity982 commented Jul 22, 2026 •

edited by cursor Bot

Loading

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

codecov Bot commented Jul 26, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 10, 2026

Uh oh!

adity982 commented Aug 10, 2026

Uh oh!

EricGustin commented Aug 13, 2026

Uh oh!

greptile-apps Bot commented Aug 13, 2026

Important Files Changed

Flowchart

Uh oh!

greptile-apps Bot Aug 13, 2026

Uh oh!

greptile-apps Bot Aug 13, 2026

Uh oh!

EricGustin Aug 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Command	Resolves to
`arcade org list`	`https://coordinator.tenant.example.com`	correct
`arcade org --host other.com list`	`https://other.com`	correct
`arcade org --port 8443 list`	`https://cloud.arcade.dev:8443`	wrong host
`arcade org --tls list`	`https://cloud.arcade.dev`	wrong host
`arcade org --no-tls list`	`http://cloud.arcade.dev`	wrong host

Uh oh!

Conversation

adity982 commented Jul 22, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Design decisions

Test plan

Author checklist

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov Bot commented Jul 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Aug 10, 2026

Uh oh!

adity982 commented Aug 10, 2026

Uh oh!

EricGustin commented Aug 13, 2026

Uh oh!

greptile-apps Bot commented Aug 13, 2026

Greptile Summary

Confidence Score: 4/5

Important Files Changed

Flowchart

Uh oh!

greptile-apps Bot Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

EricGustin Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

adity982 commented Jul 22, 2026 •

edited by cursor Bot

Loading

codecov Bot commented Jul 26, 2026 •

edited

Loading