Repository navigation
Conflict rules become confirmable warnings (NR add-ons, MFG, anti-cheat, Store) - #79
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every "can't be together" rule now returns a reason instead of refusing. The game page and the install dialog show it with "Install anyway" / "Cancel", the confirmation is stored in the install record until the selection changes, and a warning stays on the game. Settings defaults and the method picks still never choose a clashing set.
NrAddons.Conflict(s),Installer.Conflicts; the Settings checkbox andAllowSeveralNrAddonsare gone (old settings files still load). The installer no longer displaces add-ons it installs in the same run.[DLSSG] AdaMfgUnlockandAmpereMfgUnlockare written asfalse; a user value still wins and then shows the warning. Keys taken from the OptiScaler.ini of janblade F5 v0.1.32 (both shipped asfalse).Verified: build -warnaserror and the full suite (601 tests) pass locally. Screens to check: game page (works-in-this-game list, warning bar under the mods, ShortFuse + Lecram pair), the "Check before installing" dialog, Settings > defaults (checkbox removed).