fix(accessibility): fix missing alt for img#295
Draft
Rotzbua wants to merge 3 commits into
Draft
Conversation
Rotzbua
force-pushed
the
fix_validator_img_alt2
branch
from
December 25, 2023 00:10
9b3b614 to
5185f99
Compare
Error: An img element must have an alt attribute, except under certain conditions. Source: Nu Html Checker
Rotzbua
force-pushed
the
fix_validator_img_alt2
branch
from
January 4, 2024 10:38
5185f99 to
d1f2b3b
Compare
keunes
reviewed
May 8, 2024
keunes
left a comment
keunes
left a comment
Member
There was a problem hiding this comment.
Seems I never submitted my review 🤦Sorry!
I would just rename this, as it's the whole website's menu.
Member
|
Alt approach is correct: https://www.w3.org/WAI/tutorials/forms/labels/#labeling-buttons If we want to make the menu properly accessible, we should probably set the |
Co-authored-by: Keunes <11229646+keunes@users.noreply.github.com>
Co-authored-by: Keunes <11229646+keunes@users.noreply.github.com>
Rotzbua
marked this pull request as draft
May 9, 2024 01:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error: An img element must have an alt attribute, except under certain conditions.
Source: Nu Html Checker