Fix view detection failing on ?noRedirect=1 URLs - #14
Merged
Merged
Conversation
taoshotaro
marked this pull request as ready for review
July 13, 2026 05:16
The previous fix let the view id match before any query string, which would silently drop params like ?filter=. Those should eventually be forwarded to the whiteboard, so keep them failing detection loudly and allow only ?noRedirect=1. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
taoshotaro
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?noRedirect=1(e.g./view/cycle-planning-backlog-30beca7f44e5?noRedirect=1) were not detected: the view-id regex anchored the hex id to end-of-string ($), so the Whiteboard button never injected and the popup reported "not a Custom View"./\/view\/.*?-([a-f0-9]+)(?:\?noRedirect=1)?$/so the id still matches with that param appended.extractViewIdinsrc/lib/storage.ts(popup + whiteboard) andgetWhiteboardUrlinsrc/content/inject-button.ts(button injection).Only
?noRedirect=1is tolerated, deliberately. Params that actually affect what the view shows (?filter=...) still fail detection instead of being silently dropped — the whiteboard fetches the view by id, so those params have no effect on the board today. Keeping them un-detected leaves the door open to forwarding them properly later rather than quietly ignoring them.Test plan
?noRedirect=1(id extracted);?filter=xxx,?noRedirect=1&filter=x,#frag, and non-view URLs (null)npm run build(incl.tsc --noEmit) passes?noRedirect=1view URL and opens the board